miuna9890 / pe

0 stars 0 forks source link

Able to add duplicate persons with all same attributes but different names #2

Open miuna9890 opened 4 days ago

miuna9890 commented 4 days ago

Step 1: add n/John Doe c/ABC Inc. p/98765432 e/johnd@example.com a/John street, block 123, #01 01 Step 2: add n/Jon Doe c/ABC Inc. p/98765432 e/johnd@example.com a/John street, block 123, #01 01 Step 3: add n/Jo Doe c/ABC Inc. p/98765432 e/johnd@example.com a/John street, block 123, #01 01

image.png

Severity: Low

Justification: I am able to add in several people(3) with different name but all other attributes are the same. In the real world, it is nearly impossible to have multiple people with the same phone number and attributes and as such i don't think it should be allowed. While the user may accidentally make mistakes and add several people with same attributes, it adds a slight inconvenience to user, but the user would be able to continue using the application

nus-se-bot commented 1 day ago

Team's Response

We allow this in our app because our app is meant for financial consultants who may have corporate clients working at the same company (and thus, same company phone numbers, company address, corporate email, and obviously same company name). This follows the principle of allowing flexibility for users.

They must have different names, which means that they are not duplicates. In fact, if you tried to repeat this with all same attributes (including name), the app would flag it as an error and inform you of duplicate persons.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]