search

miurahr / aqtinstall

aqt: Another (unofficial) Qt CLI Installer on multi-platforms
https://aqtinstall.readthedocs.io/en/latest/
MIT License
915 stars 84 forks source link

Use 'tar' filter when extracting tarfiles #707

Closed ddalcino closed 1 year ago

ddalcino commented 1 year ago

Fix #700.

This is to address a Snyk warning. The new code will only run on Python 3.11.4 and above.

Tested locally with Python 3.11.2 and 3.11.5. Although we can't see it in the code coverage with a single version of Python, I can confirm personally that both arms of the conditional are being entered.

ddalcino commented 1 year ago

Oops; looks like this change caused this failure on Windows: https://github.com/miurahr/aqtinstall/actions/runs/5997958636/job/16265345067

On that CI runner, it looks like Python 3.10 is installed, and the test is not expecting to see the warning Extracting may be unsafe; consider updating Python to 3.11.4 or greater. Let me fix that...