search

miurahr / aqtinstall

aqt: Another (unofficial) Qt CLI Installer on multi-platforms
https://aqtinstall.readthedocs.io/en/latest/
MIT License
893 stars 83 forks source link

Support python 3.11 & 3.9 #712

Closed nrbnlulu closed 9 months ago

nrbnlulu commented 10 months ago

Support python 3.11 and 3.9 the workflows only run for 3.10 and I can't install on 3.11

ddalcino commented 10 months ago

Works OK for me on python 3.8, 3.9, 3.10, and 3.11.

If you're trying to report a bug, we can't help without more information. The 'bug report' template exists for a reason, and I suggest you use it.

nrbnlulu commented 10 months ago

Never said that there is a bug. I said it didn't worked for me and the workflows doesn't cover python 3.9 3.8 3.11

pzhlkj6612 commented 10 months ago

@nrbnlulu

it didn't worked for me...

To you, that's exactly a bug, isn't it?

I think you should post the error message here or in a new issue with the 'bug report' template.

nrbnlulu commented 10 months ago

@pzhlkj6612

To you, that's exactly a bug, isn't it?

I already fixed that.

Though this doesn't mean that aqtinstall "supports" anything other than 3.10.

pzhlkj6612 commented 10 months ago

To you, that's exactly a bug, isn't it?

I already fixed that.

OK, good to hear that.

It seems that the Azure Pipeline tests Python 3.9: https://github.com/miurahr/aqtinstall/blob/4f2bdda951910cec08037a58f23c503257b38111/azure-pipelines.yml

As @nrbnlulu said, the GitHub Actions workflow doesn't cover python 3.8, 3.9 and 3.11. Adding them to "workflows/test-install-qt.yml" looks OK. Opinions?

nrbnlulu commented 10 months ago

It seems that the Azure Pipeline tests Python 3.9: https://github.com/miurahr/aqtinstall/blob/4f2bdda951910cec08037a58f23c503257b38111/azure-pipelines.yml

Thanks. so, this is closeable. Sorry for the redundant issue.

pzhlkj6612 commented 9 months ago

Well, please wait. Python 3.8 & 3.11 are indeed not covered by our CI and we (including you) could discuss it in this issue, so you can keep this issue open. @nrbnlulu

miurahr commented 9 months ago

I can accept PR to add python 3.8 and 3.11 in CI. It depends only on free tier service cpu time on Azure-Pipelines or Github Actions.