search

miurahr / aqtinstall

aqt: Another (unofficial) Qt CLI Installer on multi-platforms
https://aqtinstall.readthedocs.io/en/latest/
MIT License
913 stars 84 forks source link

Update `aqt/combinations.json` #751

Closed github-actions[bot] closed 7 months ago

github-actions[bot] commented 9 months ago

The ci/generate_combinations.py script has detected changes to the repo at https://download.qt.io. This PR will update aqt/combinations.json to account for those changes.

Posted from the check_combinations action

miurahr commented 8 months ago

This removes many entries rather than just adding 6.7.0. Why?

ddalcino commented 7 months ago

This removes many entries rather than just adding 6.7.0. Why?

Missing architectures:

The relevant code is on line 45:

https://github.com/miurahr/aqtinstall/blob/61e18c869f94a222382ffc7d67c26d7d47ab6eee/ci/generate_combinations.py#L41-L51

To make sure these runs don't take too long, we are only checking for architectures in the latest version of Qt6 and a couple versions of Qt5. Currently, the latest Qt6 is 6.7.0, which is in Beta2 right now, planned to release on March 19. I don't know why Qt 6.7.0 is missing those extra architectures right now, but I'm guessing they will come back sometime before the final release.

It would probably make a lot of sense to fetch data for more than one version of Qt6; I vote for the LTS versions (6.2 and 6.5).

Missing modules for Qt 6.7.0:

We are hard-coding the module checks to check Linux, using architecture=gcc_64: https://github.com/miurahr/aqtinstall/blob/61e18c869f94a222382ffc7d67c26d7d47ab6eee/ci/generate_combinations.py#L80-L90

Qt 6.7.0 for linux does not have a gcc_64; it has been replaced with linux_gcc_64, so the function doesn't return any modules for that version of Qt.

miurahr commented 7 months ago

OK, I'd like to try adding 6.2 and 6.5. Also try to make it recognizing gcc_64 and linux_gcc_64.