Share functionlay has changed ?

miurla / morphic

An AI-powered search engine with a generative UI

https://morphic.sh

Apache License 2.0

4.97k stars 1.16k forks source link

Share functionlay has changed ? #204

Open freedomtrain opened 1 month ago

freedomtrain commented 1 month ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Before the current changes there was a share icon available to so that the query with reply could be shared with others. This seems to not be available with the current code ?

Expected Behavior

We should have the ability to share results from results page.

Steps To Reproduce

Ask a question and not the share icon is not here

Environment

- OS: MacOS 
- Browser:Chrome

Anything else?

No response

miurla commented 1 month ago

It can be enabled with the environment variable enable_share. Please see the PR for details: https://github.com/miurla/morphic/pull/142

freedomtrain commented 1 month ago

I have ENABLE_SHARE=true The issue is that the share icon is no longer on the front page. It seems that is only accessible by using the saved queries from the history panel.

On June 3, 2024 at 10:56:21 PM, Yoshiki Miura @.***) wrote:

It can be enabled with the environment variable enable_share. Please see the PR for details: #142

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

miurla commented 1 month ago

It seems that is only accessible by using the saved queries from the history panel.

Sorry, I understood. Due to the removal of router.refresh(), the share button does not become active. ref: https://github.com/miurla/morphic/pull/197