Paladin saving throws - Githubissues

mivalsten / ddb-dm-screen

MIT License

30 stars 10 forks source link

Paladin saving throws #12

Closed Mitschy closed 5 years ago

Mitschy commented 5 years ago

Paladins "Aura of Protection" doesn't work properly. I tryed a += on lines 129-135, but that doesnt work either since the value is still missing a value equal to (profiency modifier - 2) -> on a lvl 6 Paladin its off by 1, on a lvl 10 by 2 and so on.

mivalsten commented 5 years ago

While there is an error in the calculation (forgot about the cha mod or minimum of +1), I can't reproduce your error as it calculates those fine for me. Can you please upload your character's JSON file? You can access it by adding "/json" to the end of your character. First paste it to https://jsoneditoronline.org/ and remove all top nodes except "character".

Mitschy commented 5 years ago

https://jsoneditoronline.org/?id=14734065eca540829ac607fb57fb964d this should be it, good look.

mivalsten commented 5 years ago

I can't find anything wrong with the script or the data. Could you check if you are using latest version? It should be 1.2.4.

Mitschy commented 5 years ago

It's 1.2.4 and I updated it again, but it's still not working properly

Mitschy commented 5 years ago

an idea: what did you use to get those ability scores ? the base value for charisma ist 15 and +3 from the ability score improvements from lvl 4 and 8. the script is not considering this and just adds the bonus from the base score (15 -> +2) thats why there is 2 missing, or 1 with another paladin i tryed.

Edit: i used the standard array + ability score improvements to give +1 to my strength und +3 to my charisma score

mivalsten commented 5 years ago

Oh, wait, this can be indeed a race condition. I think I have an idea for a fix.

mivalsten commented 5 years ago

Ok, I was able to reproduce the error and fix that. Please verify.

Mitschy commented 5 years ago

verified, works now.