search

mivalsten / ddb-dm-screen

MIT License
30 stars 10 forks source link

Update 1 #31

Closed TeaWithLucas closed 3 years ago

mivalsten commented 3 years ago

Hey! that's very nice of you to update this script and make Readme way less self-derogatory :) Kudos!

I have few comments:

  1. is it necessary to display stat bonus twice? I'd drop the one in parenthesis in top row,
  2. while were there, i'd also display first and second row as a single div so that the elements are aligned,
  3. You dropped settings persistency, is there any particular reason for it?
  4. Could you try to flip the rows to columns? modern screens are much wider than they are tall, so that could allow to add way more information/characters on a single screen

All in all, great work and I'm really happy that you liked it so much that you actually made an effort to make it better!

TeaWithLucas commented 3 years ago

Hi @mivalsten, sorry I opened this by mistake, i'm not that great at git, thats why i closed it!

  1. My aim is to have the different sections toggleable, so you can quickly turn of abilities or saves quickly.
  2. Because with abilities you want number and mod, it is space ineffecent, i think i have come up with a good solution in the latest version
  3. I was using a old script i did back in 2019 and was merging them with your new code and it wasn't implemented, it should be now.
  4. I did this before even seeing this, so i aggree :D

I've been working on it for the last couple of days and was mostly doing it for myself, wasn't sure if you'd like the new style. Anyway, the most recent version is here: https://github.com/TeaWithLucas/DNDBeyond-DM-Screen/tree/master

screenshot