An attempt to add paging support in a generic way.

mivano / azure-cost-cli

CLI tool to perform cost analysis on your Azure subscription

Apache License 2.0

866 stars 110 forks source link

An attempt to add paging support in a generic way. #147

Closed mivano closed 5 months ago

DanielSpindler83 commented 6 months ago

I did some testing on this branch and it works for calls I make that need more pages and no known impact to calls for single pages. Looks good to go.

mivano commented 5 months ago

Thanks for validating. By the way, I did not want to overrule your PR, as you also took the time to come up with an implementation. So I hope you are okay with this approach as well?

DanielSpindler83 commented 5 months ago

100% ok with this approach. It is nice and clean. I am enjoying the learning and engagement. Thanks for checking.

MvRoo commented 5 months ago

I have been testing costByResource, which didn't support paging before, and it is looking fine until now. Have exported > 38k lines on one occasion.

mivano commented 5 months ago

Thanks for validating this change guys! I will merge it and prepare a package.