mivion / swisseph

Swiss Ephemeris binding for node.js
GNU General Public License v2.0
205 stars 72 forks source link

update to 2.08 and changes for node v12 #63

Closed timotejroiko closed 5 years ago

timotejroiko commented 5 years ago

Hello, i made some changes a while ago, now i finally had some time to make this PR. Im currently using these changes in production and so far it seems to be working, however it would be good if someone can confirm these changes are properly implemented since im not proficient in C++ and there are some things i was unable to fix.

changes:

todo:

im not sure how to go about fixing the remaining issues above without causing problems, so it would be great if someone could help.

keel commented 5 years ago

Thanks for your work! especially the warnings I can not fix. but I'm not sure all this changes are perfectly right, so maybe @mivion should take a look.

mivion commented 5 years ago

Thanks for work. Tests are passed for node v8.0 and 10.0. Should we add v12.0 for test? So I merge this request. If some thing wrong, please make new PR.