miwarnec / DOTSNET

Public DOTSNET issue tracker
20 stars 0 forks source link

FixedString* serialization changes from IBit* to Network* #63

Closed Will-Carson closed 2 years ago

Will-Carson commented 2 years ago

This is less of a feature request and more of a question. IBitReader/Writer would only write the content of FixedString types to messages, where NetworkReader/Writer writes the whole FixedString, empty bytes and all. What is the reason for this regression? Did we get a huge performance increase? If you say it's worth it I'll believe you, but my understanding is that CPU time is generally a lot less expensive then network traffic, so the IBitReader/Writer tradeoff seems better to me. In the meantime I will be writing an extension to NetworkReader/Writer to mimic the behavior of IBit, but I am curious as to the explanation for this change.

miwarnec commented 2 years ago

Hi, yes thats true for two reasons:

in other words, its faster and still bandwidth efficient thanks to the delta compression filtering out the bytes that are same as last time :)