miwarnec / uMMORPG

4 stars 0 forks source link

Monster does not have nextTarget #2

Open mr-short opened 6 years ago

mr-short commented 6 years ago

Versions (please complete the following information)

Describe the bug I had a Monster that casted a buff on itself, but didn't reaggro when I was outside the aggro range.

When a Monster casts a buff on itself, it transfers target from Player to itself. So it no longer maintains aggro on the player, because it does not have a nextTarget property like the Player does. So if the Player is standing outside the aggro range when the buff ends, the Monster just stands there.

To Reproduce Steps to reproduce the behavior, please explain every single click that is needed:

  1. Give a monster an attack skill
  2. Give a monster a SELF buff skill with a delay
  3. Run play mode
  4. Stand near monster while it attacks
  5. Once monster starts casting buff, move out of aggro range (but still within follow range)
  6. Watch as monster just sits there and does not follow/attack player

Expected behavior Monster starts chasing/attacking Player after buffing itself.

System (please complete the following information):

Additional context

Player.cs:

    // the next target to be set if we try to set it while casting
    // 'Entity' can't be SyncVar and NetworkIdentity causes errors when null,
    // so we use [SyncVar] GameObject and wrap it for simplicity
    [SyncVar] GameObject _nextTarget;
    public Entity nextTarget
if (EventSkillRequest()) {
    Skill skill = skills[currentSkill];
    nextTarget = target; // return to this one after any corrections by CastCheckTarget
    if (CastCheckSelf(skill) && CastCheckTarget(skill))

Monster.cs:

if (EventSkillRequest()) {
    Skill skill = skills[currentSkill];
    if (CastCheckSelf(skill) && CastCheckTarget(skill)) {
miwarnec commented 6 years ago

thanks, looking into it again now

miwarnec commented 6 years ago

Looks like I still can't reproduce it. I added the windwalk skill to the bandit, but it can cast it just fine

mr-short commented 6 years ago

@vis2k But does it continue to attack you afterwards? My monsters will just sit there when I'm right outside the aggro range.

miwarnec commented 5 years ago

@mr-short can you make a video please?

mr-short commented 5 years ago

https://streamable.com/sgkvb

miwarnec commented 4 years ago

@mr-short your video cuts of right at the end before we are supposed to see the bug. could you include the moment where it can't attack you anymore please?

AbraKabastard commented 4 years ago

@mr-short your video cuts of right at the end before we are supposed to see the bug. could you include the moment where it can't attack you anymore please?

Hello! at 0:03 seconds you can see the NPC AI is about to iterate to its buff spell and the player leaves the radius, and then the npc casts a SELF TARGET buff which changes its TARGET to itself and then after the buff is done it cant find its original target after the buff is finished casting because he just ran slightly out of that collider and that target is not stored anywhere.. instead it depends on AggroArea to "reaggro".

Edit: Made some changes to lingo to make it clear whats happening code wise

jonmalave commented 4 years ago

@mr-short and @AbraKabastard save yourself the headache and just trash uMMORPG and move on over to MMORPG Kit. Way better MMORPG asset, stable, more features, better developer support, and cheaper!

Sehlor commented 4 years ago

Holy crap dude, how much of a butthurt you can be to spam a git issue tab with a moronic comments, do yourself a favor and go take a nap and calm down :)

jonmalave commented 4 years ago

Holy crap dude, how much of a butthurt you can be to spam a git issue tab with a moronic comments, do yourself a favor and go take a nap and calm down :)

stop being such a fanboy and kissing @vis2k ass... vis2k is a hypocrite and cares less about supporting his flagship products, and loves burning bridges because he can't handle the truth (when some community members who actually contributed good things call him out on his shit)

Sehlor commented 4 years ago

Here is a taste of truth: you and your boys started a framework, realized its a fking hard job to do, left it without a commit for 3 months and came back crawling to the asset and trying to make vis2k do things you can't manage on your own, how is that?

Cheers :)

jonmalave commented 4 years ago

Here is a taste of truth: you and your boys started a framework, realized its a fking hard job to do, left it without a commit for 3 months and came back crawling to the asset and trying to do things you can't manage on your own, how is that?

Cheers :)

die hard fanboy right here... lol! that's not even close to the truth lmao... you missing all the points but of-course you would because your head is very far up someones ass to see anything from the outside in.

Sehlor commented 4 years ago

So, straight to the insults means you are out of things to say. Cheers mate, but seriously go get some sleep it'll be good for you :)

jonmalave commented 4 years ago

So, straight to the insults means you are out of things to say. Cheers mate, but seriously go get some sleep it'll be good for you :)

FYI i'm not part of any team that is making a framework lol... so let's talk about that fake news right there lol! I'm not part of @wovencode's team, but he has tons of valid points that I support and I 100% know that he was one of the best things that has ever happened to uMMORPG community contributing tons of amazing work, but yet @vis2k shuns hims, and you probably follow suite because you're a fanboy vs looking at how @vis2k conducts business...

Am i butthurt you ask? na... i'm simply passionate about exposing a person who pretends to be all about community, says one thing but does another, provides advise about something but yet doesn't even walk the walk himself and lead by example...

I'm not the one that needs sleep your homeboy does... a loooong sleep where hopefully he wakes up and realizes how bad his morals are and makes some serious changes and stop hurting the game development community.

Sehlor commented 4 years ago

He walks the walk, he freaking developed an open source networking library with community members. Consistently improves assets and even the database thing got a lot better but what you and your goons doesn't understand is this is a BASIC Framework with BASIC Startup, as advertised and you need to view as such.

The thing is basically fucking murmuring about a guy who is doing a decent enough ( not perfect, nobody is ) job which you based your fucking product on ( open mmo based on mirror ) and still can talk shit?

That is proper hypocrite behaviour nothing less, nothing more.

Regarding the issues, as i said IF you are gonna make an mmo, you can iron out those things without a problem in a day.

IF you are just putting together a game that runs, it is more than okay to use it as is and develop a game, which people do.

Regarding to contributing to community, i don't count getting paid to do something and leave it suddenly TWICE count as community work, its just running and disappearing and blaming someone else, stop acting like a child and own your mistakes, stop crying out and start listening as 99% of community does.

Before you ask, i answer: NO its not a sheep like behaviour its how communities work, with proper communication, not like acting out like a child and throw a tantrum.

And don't say you are not throwing a tantrum, it is a proper tantrum, you are putting links to a morons asset which got taken down 3 times for stealing code, please think before you type.

jonmalave commented 4 years ago

He walks the walk, he freaking developed an open source networking library with community members. Consistently improves assets and even the database thing got a lot better but what you and your goons doesn't understand is this is a BASIC Framework with BASIC Startup, as advertised and you need to view as such.

The thing is basically fucking murmuring about a guy who is doing a decent enough ( not perfect, nobody is ) job which you based your fucking product on ( open mmo based on mirror ) and still can talk shit?

That is proper hypocrite behaviour nothing less, nothing more.

Regarding the issues, as i said IF you are gonna make an mmo, you can iron out those things without a problem in a day.

IF you are just putting together a game that runs, it is more than okay to use it as is and develop a game, which people do.

Regarding to contributing to community, i don't count getting paid to do something and leave it suddenly TWICE count as community work, its just running and disappearing and blaming someone else, stop acting like a child and own your mistakes, stop crying out and start listening as 99% of community does.

Before you ask, i answer: NO its not a sheep like behaviour its how communities work, with proper communication, not like acting out like a child and throw a tantrum.

And don't say you are not throwing a tantrum, it is a proper tantrum, you are putting links to a morons asset which got taken down 3 times for stealing code, please think before you type.

I think you totally missed the part where i said "i'm not part of @wovencode's team" or making a framework of any kind lol!!

Bro... get some sleep! relax... it will be good for you (when you wake up you will actually be able to read what i wrote clearly without the fuzzy vision)

jonmalave commented 4 years ago

He walks the walk, he freaking developed an open source networking library with community members. Consistently improves assets and even the database thing got a lot better but what you and your goons doesn't understand is this is a BASIC Framework with BASIC Startup, as advertised and you need to view as such.

The thing is basically fucking murmuring about a guy who is doing a decent enough ( not perfect, nobody is ) job which you based your fucking product on ( open mmo based on mirror ) and still can talk shit?

That is proper hypocrite behaviour nothing less, nothing more.

Regarding the issues, as i said IF you are gonna make an mmo, you can iron out those things without a problem in a day.

IF you are just putting together a game that runs, it is more than okay to use it as is and develop a game, which people do.

Regarding to contributing to community, i don't count getting paid to do something and leave it suddenly TWICE count as community work, its just running and disappearing and blaming someone else, stop acting like a child and own your mistakes, stop crying out and start listening as 99% of community does.

Before you ask, i answer: NO its not a sheep like behaviour its how communities work, with proper communication, not like acting out like a child and throw a tantrum.

And don't say you are not throwing a tantrum, it is a proper tantrum, you are putting links to a morons asset which got taken down 3 times for stealing code, please think before you type.

and for the record I did thank @vis2k for creating Mirror... but his support for uMMORPG sucks balls... what part of that did you miss. I'm entitled to my opinion about a developer providing shitty support for their asset. I reported an issue and it's been way over a month still no fix.

Am I a coder? Yes, i'm a coder... a web developer with a passion for 3D game development, but I use frameworks to prototype my ideas and maybe I want to use a framework to make a game possibly? Call me Noob... i'll take it! But the point you keep missing is @vis2k banks on all the Noobs like myself who want a drag and drop game making framework experience, and if we ask for help we are told tough shit! You paid $80 (I wrote all this code for you, go learn to code)....

Most people who know how to code games very well will never bother with such a framework... because well they can build it themselves. Most sales are made on the Asset Store from Noobs looking to toss together a game without much coding experience.

How many successfully games have you seen made with uMMORPG in past 5 years??? I have yet to see 1... WHY because all the sales where from Noobs who tried the asset for a few months than moved on when they realized they can't build a game with it.

I never ask for a damn feature since I used this asset, I simply asked for something to be fixed that was tested out the box to be broken! Every time I have submitted a request for something to be fixed, can't recall a time when it was ever properly addressed.

@vis2k get's his $80 screw me right, thanks for the payment... bye now. Great business modal he has going here.

UberWiggett commented 4 years ago

He also lies and steals. Hi Sehlor! hope you projects are going well :) Not sure if you're aware or not but I was banned merely for asking for a refund, which meant I lost access to my showcase channel and the code snippets I stored there. Vis made no effort to give me that code and in fact blocked me on discord saying he would refund me. I spent 5 weeks trying to email between Vis and Unity and in the end Vis refused to honour the refund, after collecting the personal information of myself and my family, and after Unity had supported the actions of removing access to both ummorpg and usurvival. Thankfully, when unity discovered that Vis had not honoured the refund, they reinstated the asset kits to my account so I did not end up out of pocket $120USD.

Since then I have been contacted by at least 7 people who state that they claimed the "no questions asked" refund even before I did, and were still waiting for a refund. According to Unity's policy, Unity will only pay for the refund if the purchase was made within 6 months of the request, otherwise it is up to the developer to honour the refund, this is why Vis posted that part calling unity liars, he doesn't want to be liable for another country's refund laws, Vis also has purposefully ignored requests within those bounds, responding after the 6 month period.

He has also commissioned work from artists with contra arrangements, only to have them work for a month and then cancel the contract (leaving them with nothing for their time). And he has introduced features he said he wouldn't ever add, mere days after his update broke the same feature made by an addon dev. Then features he promised he would make freely, he then turned around and demanded more money for.

Vis put a lot of effort into building the system he wanted, but you have to also recognise he put a lot of effort into making it profitable for him, without a care for those who supported him.

jonmalave commented 4 years ago

He also lies and steals. Hi Sehlor! hope you projects are going well :) Not sure if you're aware or not but I was banned merely for asking for a refund, which meant I lost access to my showcase channel and the code snippets I stored there. Vis made no effort to give me that code and in fact blocked me on discord saying he would refund me. I spent 5 weeks trying to email between Vis and Unity and in the end Vis refused to honour the refund, after collecting the personal information of myself and my family, and after Unity had supported the actions of removing access to both ummorpg and usurvival. Thankfully, when unity discovered that Vis had not honoured the refund, they reinstated the asset kits to my account so I did not end up out of pocket $120USD.

Since then I have been contacted by at least 7 people who state that they claimed the "no questions asked" refund even before I did, and were still waiting for a refund. According to Unity's policy, Unity will only pay for the refund if the purchase was made within 6 months of the request, otherwise it is up to the developer to honour the refund, this is why Vis posted that part calling unity liars, he doesn't want to be liable for another country's refund laws, Vis also has purposefully ignored requests within those bounds, responding after the 6 month period.

He has also commissioned work from artists with contra arrangements, only to have them work for a month and then cancel the contract (leaving them with nothing for their time). And he has introduced features he said he wouldn't ever add, mere days after his update broke the same feature made by an addon dev. Then features he promised he would make freely, he then turned around and demanded more money for.

Vis put a lot of effort into building the system he wanted, but you have to also recognise he put a lot of effort into making it profitable for him, without a care for those who supported him.

@vis2k only likes fanboys who don't question his business practices or challenge him...