miwarnec / uMMORPG

4 stars 0 forks source link

Characters not saved when they disconnect #30

Closed Ghetaldus closed 4 years ago

Ghetaldus commented 4 years ago

Versions (please complete the following information)

Describe the bug When you close client OnServerDisconnect runs which calls DoServerDisconnect coroutine and that is supposed to save charecter to database. It does not do that anymore.

To Reproduce Steps to reproduce the behavior, please explain every single click that is needed:

  1. Open Unity Editor '...'
  2. Build for Windows '....'
  3. Run Editor as server
  4. Run Build as client
  5. Start server only
  6. Start client, create account and login
  7. Create character and enter the game
  8. Close/Quit client
  9. Look in servers console that character has not been saved ("saved: characterName" message does not appear)

Expected behavior When client disconnects character should be saved to database.

System (please complete the following information):

Additional context This was working fine before latest few updates. I have just tested this with 1.179 version and that one works fine. I guess something have changed in Mirror.

miwarnec commented 4 years ago

looking into it now

miwarnec commented 4 years ago

can confirm, we broke Mirror :/

miwarnec commented 4 years ago

I fixed it: https://github.com/vis2k/Mirror/issues/1359 fix will be in next uMMORPG release.

miwarnec commented 4 years ago

nice find @Ghetaldus !