mixOmicsTeam / mixOmics

Development repository for the Bioconductor package 'mixOmics '
http://mixomics.org/
154 stars 51 forks source link

Extraneous output printed by testthat checks #182

Closed Max-Bladen closed 2 years ago

Max-Bladen commented 2 years ago

🐞 Describe the bug:

(1)The output of the testthat function occasionally prints dataframes, auroc values and progress bars for specific tests. This interferes with reading the output and locating areas where tests have warnings or have failed.

(2) After PR #181 (fix for Issue #164), the tune.spls tests within test_tune.spls.R result in the following warning: The SGCCA algorithm did not converge


🤔 Expected behavior:

(1) Only the output which relates to the testing output should be should. (2) The tuning process should converge on an answer - as to also clean up the output of the tests and prevent there always being 2 warnings raised.


💡 Possible solution:

(1) Go through test cases which are printing certain variables and remove those print() lines. (2) Adjust the seed value (and therefore the "true" keepX and keepY) of those tests to preventing lack of convergence.