search

mixbytes / zkllvm-doomreplay

zkllvm proving of Doom videogame state transition
GNU General Public License v2.0
0 stars 0 forks source link

Deal with char input arrays #20

Closed BoogerWooger closed 1 year ago

BoogerWooger commented 1 year ago

Deal with error or change logic to support

1) Such piece of code: https://github.com/mixbytes/zkllvm-doomreplay/blob/e8fbdd173603f8657866c38a133fbf46204438f0/zkldoom/z_main.c#L53-L72

(with local USER_INPUT[118] array)

fails with error

Assertion failed at /home/boogerwooger/zkllvm/libs/assigner/include/nil/blueprint/parser.hpp:171:
        operation->isCast()

2)

This piece of code: https://github.com/mixbytes/zkllvm-doomreplay/blob/32fb9e860dc5b91fe7a8aa814afc719082da4cf9/zkldoom/z_main.c#L36-L58

(with global USER_INPUT[118] array) fails with

Segmentation fault

in assigner

BoogerWooger commented 1 year ago

work with char array and compaison in the loop seems like to be fixed at https://github.com/NilFoundation/zkllvm-assigner/commit/26e0a6905fec0b2019bb256ef3a646da219cdce3