mixed-plate / mixedplate

MIT License

0 stars 0 forks source link

Review: Navbar & About Us Page #6

Open kayleeagorilla opened 1 week ago

kayleeagorilla commented 1 week ago

Overview

We are going to review the Form and Home page.

Review Branch

review-6

Files to review

File 1: Navbar File 2: About Us page

Checklists

Architecture Design JS React

Due date

9/23/24

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414f24/morea/review/reading-idpm-review.html

ndang562 commented 1 day ago

NavBar: Meteor.user().username can make it difficult to distinguish between a non-logged-in user and a user with an empty username

CarolinaTaylor commented 1 day ago

AboutUs.jsx line 10 all first initial letters should be upper case, add more content about spire company

kayleeagorilla commented 1 day ago

File 1:

Lines 29 - 31: Change the id of each Nav.Link. We are not using "add-stuff-nav" and "list-stuff-nav"
Line 34: Change id to Nav.Link. We are not using "list-stuff-admin-nav"

File 2:

Just make sure to add more info, etc.

zeb1283 commented 1 day ago

NavBar - change id's of navbar links, currently outdated. About Us - Same thing, currently little to no information held within the page. Add images, divs, etc.

XiaoKChenEdu commented 1 day ago

File 1: Update the Navbar, links, and IDs.

File 2: Update/Add information.

darriusdacquel commented 1 day ago

File 1: Fix duplicate key for Nav.Link in the /list and /aboutus routes. File 2: Move inline styles (e.g., style={{ minHeight: '80vh', paddingTop: '5vh' }}) to a CSS/SCSS file for better styling management.

jairabp commented 1 day ago

File 1: Line 29: Finance Form</Nav.Link>, id is outdated to template styling

File 2: Line 10: About Us information Title of tab should all be capitalized for professionalism