mixed-plate / mixedplate

MIT License
0 stars 0 forks source link

Review 11 Project Code #70

Open darriusdacquel opened 4 days ago

darriusdacquel commented 4 days ago

Overview

We are going to review the Admin page and 4011 page.

Review Branch

main

Files to review

File 1: AdminPanel.jsx File 2: 4011.js

Checklists

Architecture Design JS React

Due date

11/25/24

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414f24/morea/review/reading-idpm-review.html

darriusdacquel commented 4 days ago

File 1: Add a success/failure toast or notification system instead of alert() to provide non-blocking feedback. File 2: Use constants for repeated strings like "Interest", "Principal", "% of Core Op Budget" to avoid hardcoding.

jairabp commented 4 days ago

File 1: Create a markdown reference sheet to understand what each role can access and edit. File 2: Add comments that label each section of code and what part of the 4001 sheet it is referring to.

ndang562 commented 4 days ago

File 1: Adding appropriate fallback messages when users is empty. File 2:Use a loading spinner or a visually engaging placeholder.

CarolinaTaylor commented 3 days ago

File 1 and 2 : add more comments to know what the code is doing.