search

mixer / beam-client-java

Beam API client written in Java.
https://dev.mixer.com
MIT License
22 stars 28 forks source link

Feature/jwt #43

Closed JamyDev closed 8 years ago

Beam-Jenkins commented 8 years ago

@JamyDev, thanks for your PR! By analyzing the blame information on this pull request, we identified @ProbablePrime to be a potential reviewer

ProbablePrime commented 8 years ago

Looks good, Shame we don't have many tests for this. Something to consider later.

Would like to see expired JWT handling. If not for the app would be good for the client. Should be no reason to do that right this second though it can wait.

JamyDev commented 8 years ago

JWT expiring will be added today. One thing I didn't have time to do is add the actual data parsing for each of the events that livesubscribe can register.

ProbablePrime commented 8 years ago

this is LGTM

ProbablePrime commented 8 years ago

If there's no objections i want to get this in. I'm writing up a constellation tutorial, would be great to add java to the list of clients in that tutorial. @JamyDev ?