search

mixmark-io / turndown-plugin-gfm

:octocat: Turndown plugin to add GitHub Flavored Markdown extensions
MIT License
92 stars 33 forks source link

Conditionally force MD for tables without THEAD #16

Open rDuckDev opened 5 years ago

rDuckDev commented 5 years ago

Revision of pull request #10 by @laurent22.

I agree that the desired behavior is application-dependent; however, @oliverguenther raises a valid argument that using GitHub's default implementation is much more clear.

P.S. - sorry for the duplication of #10 and (my failed attempt with) #15.

krystof-k commented 5 years ago

Hey @domchristie, any chance this could get merged? Thanks!

laurent22 commented 5 years ago

@krystof-k, if that can be of any help, I've implement this and other features in my fork:

https://github.com/laurent22/joplin-turndown https://github.com/laurent22/joplin-turndown-plugin-gfm

Note that those are meant to support the Joplin web clipper but it could also work for you depending on your use case (the full list of changes for each fork is at the top of the readme). I assume that @domchristie's code is more general purpose.

krystof-k commented 5 years ago

@laurent22 cool, I'll try it. Thanks!

laurent22 commented 5 years ago

They both got a npm package by the way: npm install joplin-turndown-plugin-gfm && npm install joplin-turndown

Dagur commented 4 years ago

So what is the status of this PR? Should I just go ahead and use joplin-turndown-plugin-gfm?