Do no escape urls in text nodes

mixmark-io / turndown-plugin-gfm

:octocat: Turndown plugin to add GitHub Flavored Markdown extensions

MIT License

92 stars 33 forks source link

Do no escape urls in text nodes #23

Closed fredck closed 1 year ago

fredck commented 4 years ago

Fixes domchristie/turndown#324 (previously #22 here).

fredck commented 4 years ago

Note that this change also upgrades dependencies because domchristie/turndown#324 happens in Turndown v5.

martincizek commented 4 years ago

As explained in this comment at the corresponding issue, the escaping needs to be Markdown-context dependent in order to be correct.

domchristie/turndown#339 was filed to allow context-dependent processing and I'd also vote for a single-pass escaping mechanism (also referred to in domchristie/turndown#324) to allow treating similar cases systematically and without side effects.

fredck commented 1 year ago

Outdated

martincizek commented 1 year ago

Btw. this will be addressed when gfm-escape is integrated.