mixmaxhq / mongo-cursor-pagination

Cursor-based pagination for Mongo
https://www.mixmax.com/careers
MIT License
229 stars 72 forks source link

fix: properly page through undefs and nulls #329

Closed jsalvata closed 2 years ago

jsalvata commented 2 years ago

Changes Made

Potential Risks

It is unclear whether the conditions used to check for undefined and null (or non-undefined, non-null, and combinations) will use indices efficiently. But this only happens in the specific case where this change kicks in: it will not alter the performance of existing correct code.

Test Plan

See unit tests.

Checklist

mixmax-bot commented 2 years ago

:tada: This PR is included in version 8.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: