search

mixmaxhq / nodemailer-plugin-inline-base64

Nodemailer plugin to inline base64 images
MIT License
44 stars 11 forks source link

Is this duplicating native functionality? #28

Open falcononrails opened 7 months ago

falcononrails commented 7 months ago

I stumbled upon this feature in nodemailer. The option attachDataUrls needs to be passed for it to add the images as attachments. Doesn't this library serve the same purpose? Unless the native feature doesn't handle base64 encoding explicitly and that's what this library achieves?

falcononrails commented 7 months ago

I just tested attachDataUrls with an img tag that contains base64: the resulting email contains the image rendered correctly. So I guess yes, nodemailer now natively supports this lib's functionality.