Support setting image title

mixn / carbon-now-cli

🎨 Beautiful images of your code — from right inside your terminal.

MIT License

5.77k stars 121 forks source link

Support setting image title #206

Open jloewe opened 6 months ago

jloewe commented 6 months ago

Is your feature request related to a problem? Please describe. When you open carbon, you can specify an image title which is included in the screenshot (have a look at the example).

Example Carbon URL

Describe the solution you’d like:

automatically set the title when a file is used
flag to manually specify the title

Describe alternatives you’ve considered:

leaving the title out, which is not favorable when you have multiple screenshots next to each other

Additional context: You can specify the image title using the tb query parameter.

mixn commented 6 months ago

Hey @jloewe, thanks for opening! :) I wasn’t aware this was a thing. I’ll try to make some time and add it asap, since it’s just another param, shouldn’t be too much work.

jloewe commented 6 months ago

Hey @jloewe, thanks for opening! :) I wasn’t aware this was a thing. I’ll try to make some time and add it asap, since it’s just another param, shouldn’t be too much work.

Thank you in advance! Take your time. I took a look at it, but I'm not sure if I could submit a qualified PR. It looks like part of your module api would have to be changed (Prompt.getFile would need to return the file and the name if it is specified, or another getter for the file name could be added). If you want, I can try to implement this, but I'm not sure if I would match your preferred style.

mixn commented 4 months ago

Been quite swamped since the beginning of the year, but I will tackle a new release of the CLI soon and, amongst other things, address this (somehow.) 🙂 Thanks for your patience, appreciated! @jloewe