Respect ip parameter in people calls

mixpanel / mixpanel-java

Other

49 stars 37 forks source link

Respect ip parameter in people calls #11

Closed evanmp closed 10 years ago

evanmp commented 10 years ago

We call the deliver method when sending people updates or event updates. The ipParameter argument is used to set ip=1 or ip=0 for the requests generated by deliver. In the absence of ipParameter for people updates, we default to appending geolocation information as if ip=1 had been passed. We should update this method to make it possible to disable geolocation information for people updates.

joeatwork commented 10 years ago

You are the man! Thanks for the PRQ! Come requests

would you mind writing a test to go with this change? Just confirming that the parameters are sent correctly to sendData would work.
would you make sure you've been able to build and run a test program with this change?

Come see me if this sounds tough or I can give you a hand!