search

mixpanel / mixpanel-js

Official Mixpanel JavaScript Client Library
https://mixpanel.com/help/reference/javascript
Other
885 stars 312 forks source link

Incomplete multi-character sanitization on utils.js getQueryParam function 2 #446

Open JiatangDong opened 1 month ago

JiatangDong commented 1 month ago

Happy to see the issue #443 fixed so quickly

However, the problem is not solved yet. CodeQL reports another issue "This does not escape backslash characters in the input."

JiatangDong commented 1 month ago

Maybe you can consider this: https://docs.github.com/en/code-security/code-scanning/enabling-code-scanning/configuring-default-setup-for-code-scanning since the consumers like us will use it somewhere else anyway.

tdumitrescu commented 1 month ago

Feel free to open PRs with further fixes, thanks