search

mixpanel / mixpanel-node

A node.js API for mixpanel
http://www.mixpanel.com
MIT License
477 stars 159 forks source link

fix: add missing config.secret to types #225

Open gierschv opened 1 year ago

gierschv commented 1 year ago

The release 0.18.0 broke the usage of this library using TypeScript and secret in the config:

error TS2345: Argument of type '{ host: string; secret: string; debug: boolean; }' is not assignable to parameter of type 'Partial<InitConfig>'.
Object literal may only specify known properties, and 'secret' does not exist in type 'Partial<InitConfig>'.
lsthornt commented 1 year ago

Just here to add a +1 confirming that this change works in our codebase, and fixes the type issue noted in the description.

mdwallis commented 5 months ago

Following up on this thread to see if and when the PR will be merged. Thanks in advance.