search

mixpanel / mixpanel-swift

Official iOS (Swift) Tracking Library for Mixpanel Analytics
https://mixpanel.com
Apache License 2.0
434 stars 234 forks source link

Mark final attribute in MixpanelManager #553

Closed muukii closed 2 years ago

muukii commented 2 years ago

it seems there is no subclass of MixpanelManager. We could mark final attribute for it. Which probably gains performance. Rather than that, readability will gain because we could notice this class won't have a subclass, so there is no need to be concerned about side effects in modifying functions and properties.

jaredmixpanel commented 2 years ago

thanks @muukii