mixpanel / mixpanel-utils

Other
85 stars 62 forks source link

urllib2 breaks client using python3 #10

Closed gregorypease280 closed 6 years ago

gregorypease280 commented 6 years ago

It appears that this client doesn't support python3 at the moment.

 from mixpanel_api import Mixpanel as MixPanelApi
  File "/mindshow/venvs/mindhole/lib/python3.6/site-packages/mixpanel_api/__init__.py", line 3, in <module>
    import urllib2  # for sending requests
ModuleNotFoundError: No module named 'urllib2'

https://github.com/mixpanel/mixpanel_api/blob/ee7eea50b1d7845b65e0db2b15f8d808569f7bdd/__init__.py#L3

relevant stackoverflow: https://stackoverflow.com/questions/6594620/python-3-2-unable-to-import-urllib2-importerror-no-module-named-urllib2

jaredmixpanel commented 6 years ago

@gregorypease280 That is correct. This module is Python2 only, for now.

gregorypease280 commented 6 years ago

@jaredmixpanel Cool, I think it would be helpful if the README was updated to reflect this. Also are you allowing the public to submit PRs?

jaredmixpanel commented 6 years ago

@gregorypease280 I've added a note to the README. Yes, you're welcome to submit a PR and we will review it.

apurvis commented 4 years ago

any progress on this? python2 is officially deprecated in only a bit more than 2 months.

jayharan commented 4 years ago

yes any progress jared? @jaredmixpanel

jaredmixpanel commented 4 years ago

@jayharan i'm no longer the maintainer for this repo, it's @danakock. please see the existing py3 issue here: https://github.com/mixpanel/mixpanel_api/issues/12