search

mixxorz / Glass

An immersive and minimalistic chat UI for World of Warcraft
MIT License
21 stars 18 forks source link

Addon incompatibility: Spy #86

Closed mixxorz closed 4 years ago

mixxorz commented 4 years ago

Describe the bug Spy does not work with Glass.

https://www.curseforge.com/wow/addons/spy

Possibly because Glass modifies the Combat Log.

ghost commented 4 years ago

I literally have no idea why it does what it does.. or why this does anything to resolve it.. but figured I should share it at least.

By simply adding return self.db.profile to the end of the Core:OnInitialize() in init.lua I no longer have any issue with spy on Classic. It doesn't even have to be return self.db.profile.. at first I had DevTools_Dump(self.db.profile) and it seemed to work. As long as you're some how calling the array specifically.

As you can see in this screenshot

Here's the code difference

ghost commented 4 years ago

What I do know is, that minor change allows this db table to contain the missing variables.

Before change - Missing variables

After change - Variables

mixxorz commented 4 years ago

Thanks for helping with debugging!

I've made a recent change with db, do you mind trying version 1.4.1 and see if that works?

ghost commented 4 years ago

From what I can tell, it works so far on Classic.

mixxorz commented 4 years ago

Sorry just to confirm, is it working now with Spy on Classic?

ghost commented 4 years ago

Yes. SpyClassic1.1.1-release is currently working along side Glass-1.4.1-classic.

mixxorz commented 4 years ago

That's awesome!

Basically I was doing something weird with the AceDB saved variables and I think that was having unintended consequences with Spy (but curiously, no other addon). Release 1.4.1 fixes the AceDB issue, which seems to have fixed Spy compatibility as well. Awesome!

I'll close this now. Thanks for debugging!!