Mac/Win: add LAME - Githubissues

mixxxdj / buildserver

Tools for managing the Mixxx build server and build VMs.

12 stars 23 forks source link

Mac/Win: add LAME #32

Closed Be-ing closed 6 years ago

Be-ing commented 7 years ago

MP3 patents have finally expired, so we can distribute LAME in binary form for MP3 streaming and recording.

https://bugs.launchpad.net/mixxx/+bug/1294128

luzpaz commented 6 years ago

probably should assign this ticket to a milestone version

Be-ing commented 6 years ago

As far as I can tell LAME was only added to the macOS build environment but not Windows yet.

rryan commented 6 years ago

Windows support was enabled in: https://github.com/mixxxdj/buildserver/commit/9e8bcee771731920ae82f3e076d43f0fb51e5027 and the current build environment for 2.2.x should have it. Are you not seeing it?

Be-ing commented 6 years ago

Okay, nevermind then. We should update the manual to remove info about installing LAME then.

rryan commented 6 years ago

Yea, LAME still needs to be enabled by default in Mixxx though, and we can remove all the dynamic loading support.