search

mixxxdj / buildserver

Tools for managing the Mixxx build server and build VMs.
12 stars 23 forks source link

Add qtkeychain 0.9.1 support to Windows build. #53

Closed daschuer closed 5 years ago

daschuer commented 5 years ago

Fixes #48.

daschuer commented 5 years ago

Works, merge? This environment is used for master as well.

rryan commented 5 years ago

Works, merge? This environment is used for master as well.

LGTM, thanks! Did you test these environments by building Mixxx with it? http://downloads.mixxx.org/builds/buildserver/2.2.x-windows/prs/2.2-PR53-j00045-x86-release-fastbuild-static-4cc84c5-minimal.zip http://downloads.mixxx.org/builds/buildserver/2.2.x-windows/prs/2.2-PR53-j00045-x64-release-fastbuild-static-4cc84c5-minimal.zip

rryan commented 5 years ago

It looks like the qtkeychain build succeeds but 2 of the 3 files aren't copied for the amd64 build (i386 looks ok).

https://builds.renegadetech.mixxx.org/job/v2.2/job/buildserver-2.2.x-windows-prs/45/architecture=amd64,only_buildserver_capable_nodes=buildserver,platform=windows,release_type=ReleaseFastbuild/consoleText

The system cannot find the path specified.
The system cannot find the path specified.
        1 file(s) copied.
daschuer commented 5 years ago

Did you test these environments by building Mixxx with it?

Can I do this remote? How?

rryan commented 5 years ago

All files (.lib, .pdb., headers) seem present to me across both architectures :+1:

daschuer commented 5 years ago

Great, so we can merge this?

rryan commented 5 years ago

Sounds good! Thanks