Go back to Qt 5.10.1 to fix build issues on Mac Os

[daschuer]

I think it does not make a big difference for Mac OS. This way we can officially announce a 2.2 beta assuming that this succeeds and postpone the OSX Qt update to Mixxx 2.3 or later.

[Be-ing]

I don't think reverting to an outdated dependency is an appropriate way to respond to a build failure. Let's fix the build failure. As far as I can tell, updating the XCode SDK should fix it.

There are improvements for high DPI scaling on Windows in Qt 5.11. I don't want to make a release with different Qt versions for different OSs.

[rryan]

Does Qt 5.11 require us to bump the minimum required macOS version? I seem to remember it did but may be misremembering. (xcode sdk version is independent of minimum required version).

On Sun, Aug 26, 2018, 11:13 AM Be notifications@github.com wrote:

I don't think reverting to an outdated dependency is an appropriate way to respond to a build failure. Let's fix the build failure. As far as I can tell, updating the XCode SDK should fix it.

There are improvements for high DPI scaling on Windows in Qt 5.11. I don't want to make a release with different Qt versions for different OSs.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mixxxdj/buildserver/pull/55#issuecomment-416057811, or mute the thread https://github.com/notifications/unsubscribe-auth/AABnn1E_s5jxvGMc8e0NOOHCcEZY-QGtks5uUuUwgaJpZM4WM3bI .

[Be-ing]

Building Qt 5.11 failed with this error:

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -c -pipe -stdlib=libc++ -O2 -g -std=c++1z  -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -mmacosx-version-min=10.11 -fvisibility=hidden -fvisibility-inlines-hidden -fno-exceptions -Wall -W -fPIC -DQT_DEPRECATED_WARNINGS -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_EXCEPTIONS -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG -DQT_PLUGIN -DQT_ACCESSIBILITY_SUPPORT_LIB -DQT_THEME_SUPPORT_LIB -DQT_FONTDATABASE_SUPPORT_LIB -DQT_GRAPHICS_SUPPORT_LIB -DQT_CLIPBOARD_SUPPORT_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I. -I../../../../include -I../../../../include/QtAccessibilitySupport -I../../../../include/QtAccessibilitySupport/5.11.1 -I../../../../include/QtAccessibilitySupport/5.11.1/QtAccessibilitySupport -I../../../../include/QtThemeSupport -I../../../../include/QtThemeSupport/5.11.1 -I../../../../include/QtThemeSupport/5.11.1/QtThemeSupport -I../../../../include/QtFontDatabaseSupport -I../../../../include/QtFontDatabaseSupport/5.11.1 -I../../../../include/QtFontDatabaseSupport/5.11.1/QtFontDatabaseSupport -I../../../../include/QtGraphicsSupport -I../../../../include/QtGraphicsSupport/5.11.1 -I../../../../include/QtGraphicsSupport/5.11.1/QtGraphicsSupport -I../../../../include/QtPrintSupport/5.11.1 -I../../../../include/QtPrintSupport/5.11.1/QtPrintSupport -I../../../../include/QtWidgets/5.11.1 -I../../../../include/QtWidgets/5.11.1/QtWidgets -I../../../../include/QtGui/5.11.1 -I../../../../include/QtGui/5.11.1/QtGui -I../../../../include/QtClipboardSupport -I../../../../include/QtClipboardSupport/5.11.1 -I../../../../include/QtClipboardSupport/5.11.1/QtClipboardSupport -I../../../../include/QtPrintSupport -I../../../../include/QtWidgets -I../../../../include/QtGui -I../../../../include/QtCore/5.11.1 -I../../../../include/QtCore/5.11.1/QtCore -I../../../../include/QtCore -I.moc -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/OpenGL.framework/Headers -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AGL.framework/Headers -I/Users/mixxx/bs-2.2-mac-prs/amd64/environment/2.2-PR52-j00020-83aff08-osx10.7-x86_64-release/include -I../../../../mkspecs/macx-clang -F/Users/mixxx/bs-2.2-mac-prs/amd64/build/2.2-PR52-j00020-83aff08-osx10.7-x86_64-release/qt-everywhere-src-5.11.1/qtbase/lib -o .obj/qcocoawindow.o qcocoawindow.mm
qcocoawindow.mm:407:59: error: use of undeclared identifier 'NSEventTypeMouseMoved'; did you mean 'kEventMouseMoved'?
                            const auto button = e.type == NSEventTypeMouseMoved ? Qt::NoButton : cocoaButton2QtButton([e buttonNumber]);
                                                          ^~~~~~~~~~~~~~~~~~~~~
                                                          kEventMouseMoved
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/CarbonEvents.h:1721:3: note: 'kEventMouseMoved' declared here
  kEventMouseMoved              = 5
  ^
qcocoawindow.mm:408:62: error: use of undeclared identifier 'NSEventTypeMouseMoved'; did you mean 'kEventMouseMoved'?
                            const auto eventType = e.type == NSEventTypeMouseMoved ? QEvent::MouseMove : QEvent::MouseButtonPress;
                                                             ^~~~~~~~~~~~~~~~~~~~~
                                                             kEventMouseMoved
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/CarbonEvents.h:1721:3: note: 'kEventMouseMoved' declared here
  kEventMouseMoved              = 5
  ^
2 errors generated.
make[5]: *** [.obj/qcocoawindow.o] Error 1
make[4]: *** [sub-cocoa-make_first] Error 2
make[3]: *** [sub-platforms-make_first] Error 2
make[2]: *** [sub-plugins-make_first] Error 2
make[1]: *** [sub-src-make_first] Error 2
make: *** [module-qtbase-make_first] Error 2

If I understand Apple's documentation correctly, that symbol was introduced in SDK 10.12. Qt's documentation says that Qt 5.11 supports Xcode 8.2 (macOS 10.11), Xcode 8.3.3 (macOS 10.12), Xcode 9 (macOS 10.13).

[daschuer]

This means Qt's docs are wrong?

I would feel better to keep Qt 5.10.1 and not stop supporting "OS X El Capitan 10.11" which is the oldest one still receiving security updates.

We have to deal with various QT versions anyway.

[daschuer]

The time is passing by and we have still no beta builds. How about just merge this. It is OK for me to have different QT versions in MacOs and Windows.

[Be-ing]

The macOS builder has been updated to the macOS 10.12 SDK and builds are working now.

[rryan]

To close the loop on my question -- it looks like Qt 5.10 and 5.11 have the same minimum supported macOS version, 10.11 -- so I think there's no harm in updating to 5.11.