search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.43k stars 1.27k forks source link

Track colors make text unreadable with certain QT themes #10061

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: ngmstr Date: 2020-07-22T21:01:19Z Status: New Importance: Undecided Launchpad Issue: lp1888573 Attachments: [Library tracks with different Qt themes](https://bugs.launchpad.net/bugs/1888573/+attachment/5395030/+files/Library tracks with different Qt themes)

Mixxx version: 2.4.0-alpha-pre (build master r7476) OS: Manjaro i3 Edition Qt verson: 5.15.0

The problem: With certain Qt themes enabled (e.g. kvantum, which I believe is the default on this OS), all tracks which have a color assigned are displayed incorrectly in the library view. Almost all columns have a solid fully saturated background, making it very hard to read e.g. white text for a yellow track. On some skins, the normal coloring can be seen in certain places. The issue seems to occur with all built-in skins.

Changing the skin to Fusion works around the issue but is not a satisfactory solution. I have attached a screenshot showing the issue

mixxxbot commented 2 years ago

Commented by: ngmstr Date: 2020-07-22T21:01:19Z Attachments: [Library tracks with different Qt themes](https://bugs.launchpad.net/mixxx/+bug/1888573/+attachment/5395030/+files/Library tracks with different Qt themes)

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2020-07-23T14:22:19Z

those are two separate issues:

1) explicit track color opacity (0.125) set in skins is not respected or did you set it opaque manually? added in https://github.com/mixxxdj/mixxx/pull/2545

2) explicit table item text color is not respected Deere in your case: https://github.com/mixxxdj/mixxx/blob/master/res/skins/Deere/style.qss#L216

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2020-07-23T14:25:10Z

maybe related: Qt theme issue in Fedora https://github.com/FedoraQt/adwaita-qt/issues/126

mixxxbot commented 2 years ago

Commented by: ngmstr Date: 2020-07-25T19:02:09Z

The skin was left unmodified. I also saw the same issues in the LateNight skin, which is what I'm actually using in the third screenshot. Both of them have the opacity set to 0.125.

I changed it for testing and noticed that it only affected the part where the opacity is correct. i.e. in the third screenshot, the area behind the stars is affected by it, the rest isn't.

It seems to me that it's not the opacity of the entire row's background is incorrect, but that the individual fields have their own background with the wrong opacity.

I'm not the issues reported for adwaita-qt, not sure if there's any connection (I'm also not using that theme)

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2020-07-26T15:57:13Z

How does it look like with Mixxx 2.3?