search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.47k stars 1.27k forks source link

Crossfader orientation isn't saved/restored #10122

Closed mixxxbot closed 11 months ago

mixxxbot commented 2 years ago

Reported by: mxmilkiib Date: 2020-09-23T20:02:49Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1896832 Tags: easy, usability

If I set all channels to ignore the crossfader, then quit and restart, the options I had set have reset.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2021-02-22T00:44:41Z

IIRC the this was supposed to avoids situations after start that are kinda hard to debug. If the orientation switches have been changed unnoticed previously, or 'in the heat of the night'. Now (2.3) all skins (except Shade) show the crossafder switches both in 2- and 4-deck mode. Only in Tango skin they are in an unusual position, not the mixer, which is also far from the mixer.

There are at least two use cases that are affected by crossfader/orientation persistence. I assume they affect the 4-decks mode only, so we can ignore Shade skin here.

  1. multiple DJs share a computer during a set and want to switch between regular crossfader usage and 'all channels centered, crossfader ignored' without the need to flip all decks switches and show/hide the crossfader via Skin Settings.

    For that we could add an option to Preferences > Crossfader called "Ignore crossfader", plus a CO that can be mapped in skins and on controllers. Toggle "Ignore crossfader" ON does

    • (center the crossfader, store position??)
    • store orientation of all decks
    • put all decks into their default position
    • hide the crossfader in skins
    • ignore crossfader input from controllers Toggle OFF does
    • restore orientation of all decks
    • (restore crossfader position??)
    • show the crossfader in skins

  2. Save & restore the custom channel orientation across restarts Example: outer decks 3/4 are left/right, decks 1+2 are always centered. It's tempting to add a respective option into the Decks preferences page (default off). But actually, since it's tightly coupled to the crossfader and the deck page is crammed already, it should better be in the Crossfader page.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2021-02-22T21:07:15Z

I am leaning towards simply making the crossfader orientation switches persistent in all cases. This is how every 4 deck mixer and controller with crossfader assignment switches works. I think if a user wants to change these, they probably want that change to persist.

ronso0 commented 1 year ago

Another request in the forums, for the samplers https://mixxx.discourse.group/t/abs-function-only-working-on-one-sl-1200-turntable/28106/9

phil-flip commented 1 year ago

Same here!

ronso0 commented 1 year ago

Had this change in my stahs list already, here we go #12074

ronso0 commented 11 months ago

12074

mxmilkiib commented 10 months ago

If this is merged, why am I still having to set the orientation for the 4 decks/channels every time I start Mixxx?

Running 2.4-alpha-1578-gc47f67985d

ronso0 commented 10 months ago

Mixxx 2.4 is in beta for quite a while now, your alpha build does appearantly not contain the fix. FWIW I stumbled over the fix recently while testing something else XD

mxmilkiib commented 10 months ago

Oooh, there is no branch specified in the PKGBUILD, so it's using main, and that's older, I missed that!

I'll fix the mixxx-git-debug PKGBUILD that I'm using and that's in the AUR for Arch users.

And yay that it is actually fixed, ty :)