Tango Skin Warnings in 2.3

[mixxxbot]

Reported by: Holzhaus Date: 2020-11-02T22:52:37Z Status: Fix Released Importance: Low Launchpad Issue: lp1902591 Tags: skin

---

Using the Tango skin causes some warnings:

Warning [Main]: /home/jan/Projects/mixxx/src/skin/legacyskinparser.cpp:1975 SKIN ERROR at skin:vumeter_mini.xml:16 <StatusLight>: Invalid <TooltipId> in skin.xml: "_VuMeter"
Warning [Main]: ControlDoublePrivate::getControl returning NULL for ( "[VinylControl]" , "show_vinylcontrol" )

[mixxxbot]

Commented by: ronso0 Date: 2020-11-03T10:26:13Z

---

fixed the VU meter warning.

about
Warning [Main]: ControlDoublePrivate::getControl returning NULL for ( "[VinylControl]" , "show_vinylcontrol" )

This warning is thrown because it's not used in Tango (it has controls per deck). The control is present in the View menu though (unchecked). When I click it it's checked but greyed out. Doesn't make much sense. I remember that we handled that differently earlier: for example with Shade Skin Settings was greyed out because Shade doesn't have one.

[mixxxbot]

Commented by: ronso0 Date: 2020-11-03T10:42:08Z

---

When Mixxx is started with a skin that uses [Master],skin_settings for example the View menu action is available later on with other skins until restarted.

[mixxxbot]

Commented by: ronso0 Date: 2020-11-04T22:59:09Z

---

https://github.com/mixxxdj/mixxx/pull/3264

[mixxxbot]

Issue closed with status Fix Released.