search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.46k stars 1.27k forks source link

Warning about controller_input_active in the log #10228

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: ubuntu-linux-user Date: 2020-11-26T06:24:15Z Status: New Importance: Undecided Launchpad Issue: lp1905666

When Mixxx is started with a MIDI controller attached whose mapping uses a components.EffectUnit, the log contains following warning:

```
Warning [Controller]: ControlDoublePrivate::getControl returning NULL for ( "[EffectRack1_EffectUnit1]" , "controller_input_active" )
```

The key controller_input_active is used in only 3 files:

I suppose that the EffectChainSlot object might be created after initialization of the controller mapping, which seems to be too late.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2020-11-26T06:49:50Z

The initialization of the effects system is a tangled web of spaghetti and I caution anyone against touching it before https://github.com/mixxxdj/mixxx/pull/2618 is merged.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2020-11-26T08:17:42Z

I thought errors like this were recently fixed by https://github.com/mixxxdj/mixxx/pull/3329 ? @git-developer Can you try again with a recent 2.3 build?

mixxxbot commented 2 years ago

Commented by: ubuntu-linux-user Date: 2020-11-26T19:59:17Z

I cannot reproduce the problem on Ubuntu Focal using the build from ppa:mixxx/mixxxbetas (2.3 r7808).

I can reproduce the problem on Windows using build 2.2.4 (2.2 r6798) with the controller directory of branch 2.3.

I'd like to check 2.3 on Windows, too, but I don't want to touch my stable installation. Is it possible to install 2.2 and 2.3 in parallel on Windows?

mixxxbot commented 2 years ago

Commented by: Holzhaus Date: 2020-11-26T23:13:29Z

I'm pretty sure I fixed that issue in https://github.com/mixxxdj/mixxx/pull/2948.

mixxxbot commented 2 years ago

Commented by: Holzhaus Date: 2020-11-26T23:15:50Z

Ah, looks like that's in in fact a different bug.