search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.44k stars 1.27k forks source link

Not possible to set a loop which ends after the last beat #10403

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: JoergAtGithub Date: 2021-04-18T10:32:16Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1924904 Tags: beatgrid, looping Attachments: ImpossibleToSetAloopWhichEndsAfterTheLastBeat.PNG

I've some drum tracks which are intended as background beat for scratching. All are 16 or 32 beats long and it's intended to run them in a loop over the whole track. This is not possible with Mixxx, because it seems to be impossible to set a loop, which ends after the last vertical line of the beat grid. This behavior doesn't depend on Quntize setting.

I attach a screenshot, where I shifted the beat grid to make the problem better visible.

mixxxbot commented 2 years ago

Commented by: JoergAtGithub Date: 2021-04-18T10:32:57Z Attachments: ImpossibleToSetAloopWhichEndsAfterTheLastBeat.PNG

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2021-04-18T16:00:01Z

we already have a report for that with a long discussion, i just don't find it right now..

the issue is that playback stops as son as the track end is passed. you'll notice when you set that loop to end before the track end, then shift it beyond. there would need to be a special case added to the track player to NOT stop the track at the end if it's within an active loop, much like playback works in the preroll.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2021-04-18T18:47:51Z

it's https://bugs.launchpad.net/mixxx/+bug/1799574 which was not listed as it was marked as duplicate of an older bug which wasn't discussed that much.

mixxxbot commented 2 years ago

Commented by: JoergAtGithub Date: 2021-04-18T20:16:51Z

The case in https://bugs.launchpad.net/mixxx/+bug/1799574 is different, because in the case described here, the loop would end before the track end. The behavior described here depends on the beat grid.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2022-06-15T22:04:30Z

@joerg-ubuntu In your screenshot shows you have a beatjump/loopmove size of 4 beats. There are like 1.2 beats until the end, so shifting the loop wouldn't work in that case.

So, looping in general doesn't care about the beatgrid, but loop_move does care about the track end. In case a track is exactly* N beats long and Mixxx refuses to set a loop of N beats starting at the first frame/sample... that is a separate issue I guess. See lp:1856683 However, the workaround for that case would be

Am I missing something?