search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.46k stars 1.27k forks source link

Existing "Album Artist" will not be cleared by "Import From File Tags" when that field is cleared by another tag editor #11241

Open atskler opened 1 year ago

atskler commented 1 year ago

Bug Description

Existing "Album Artist" will not be cleared by "Track > Right click > Metadata > Import From File Tags" when that field is cleared by another tag editor. (This works correctly with the "Comment" field.)

Version

2.3.3-121-gd1f63374fc

OS

OpenSUSE Tumbleweed

daschuer commented 1 year ago

I think we need to treat a missing "Album Artist" as an empty string and not as "unknown" null value where the Mixxx value is adopted.

uklotzde commented 1 year ago

I think we need to treat a missing "Album Artist" as an empty string and not as "unknown" null value where the Mixxx value is adopted.

No. The check for reading ID3v2 comment frames is wrong, should be isEmpty() instead of isNull() for consistency. Resetting missing/empty properties on import is controlled by resetMissingTagMetadata.

uklotzde commented 1 year ago

The only feature that is missing is a UI option for kResetMissingTagMetadataOnImportConfigKey.

This is also a legit reason for keeping the Easy tag on this issue.

atskler commented 1 year ago

The main issue is present in 2.4 beta. Cleared the Album Artist field in foobar2000 but Mixxx will not clear it when I click Metadata, Import from file tags.