mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.53k stars 1.28k forks source link

Metadata/playback of ogg opus files broken #11356

Open fabi321 opened 1 year ago

fabi321 commented 1 year ago

Bug Description

If opus files have the file ending .ogg, it seems that they are assumed to be vorbis, and neither metadata extraction nor playback works. renaming to .opus fixes the issue, however, ogg is just a container, and can also contain vorbis encoded metadata/audio streams.

Version

2.3.2

OS

Ubuntu 22.04

daschuer commented 1 year ago

In 2.4-alpha we have switched from suffix detection to mime type detection. I think this Issues will be fixed along with it.
You can find builds here: https://github.com/mixxxdj/mixxx/suites/11454526365/artifacts/591017230 Or here: https://launchpad.net/~mixxx/+archive/ubuntu/nightlies

hsn10 commented 1 month ago

I have ogg vorbis and metadata reading doesn't work.

I dont'get why not use ffmpeg for dumping metadata and stream decoded audio to program. it will fix problems with aac m4a - some do not play in mixxx but do in ffmpeg.

ronso0 commented 1 month ago

@hsn10 which Mixxxx version are you referring to?

hsn10 commented 1 month ago

ogg metadata wont read on 2.4.1. ogg file have 2 tracks first is audio, second video single frame. tags are on both tracks.

2.3.3 is last version it played all my .m4a, .mp4. current version plays something then stops but is able to analyse file correctly including waveform.

daschuer commented 1 month ago

Can you share such as file a private message?

hsn10 commented 4 weeks ago

you can ffmpeg any flac with album picture as second video track and convert it to ogg.

I do not have copyright free sample.

daschuer commented 4 weeks ago

Can you prepare such a track for me?

hsn10 commented 4 weeks ago

ffmpeg -hide_banner -i "!input!" -map 0:a -map 0:1 -c:a libvorbis -q:a !quality! -iblock !impulsebias! -af adeclip,volume=!gain! -vf format=rgb24,scale=1000:1000:flags=lanczos -c:v libvpx -crf 10 -b:v 900k -metadata:s:v title="Album cover" -metadata:s:v comment="Cover (front)" "!output!"

daschuer commented 3 weeks ago

I did:

ffmpeg -hide_banner -i "in.flac" -map 0:a -map 0:1 -c:a libvorbis -vf format=rgb24,scale=1000:1000:flags=lanczos -c:v libvpx -crf 10 -b:v 900k -metadata:s:v title="Album cover" -metadata:s:v comment="Cover (front)" "out.ogg"

I am able to play the result with Mixxx 2.4.1-92, no metadata is shown.

Clementine does also not show Metadata. VLC Player and Totem has the Metadata as well as the Nemo File Manager cover preview.

I can not confirm that that is is woring with Mixxx 2.3.2 and 2.2.3.

Can you confirm that it is working on previous versions?

hsn10 commented 1 week ago

i do not have older one installed