N07070
commented
1 year ago It seems that there is already a pull request ; https://github.com/mixxxdj/mixxx/pull/1595
Open N07070 opened 1 year ago
N07070
commented
1 year ago It seems that there is already a pull request ; https://github.com/mixxxdj/mixxx/pull/1595
Holzhaus
commented
1 year ago It seems that there is already a pull request ; https://github.com/mixxxdj/mixxx/pull/1595
Donvt worry, that PR has been abandoned. Feel free to open a new PR. I suggest to copy the DJ-505 mapping and strip it down.
amakea
commented
1 year ago Any updates on this?
BSDguy389
commented
8 months ago Hi there, I'm quite new to github, I've created a fork in a gist of this mapping composed of two files found here : https://gist.github.com/upCASE/88fb258e85546092af18bc3ff924f752 https://gist.github.com/upCASE/c8dace3e70d565a4b1178f7013d3d738
My gist is here : https://gist.github.com/BSDguy389/5797dd43084dabd37bccee205bc28e73
I never modified the .js file, just the .xml one with MIDI learning some things. It worked perfectly on Mixxx 2.3.6 but not anymore on Mixxx 2.4. There's a conversation about it on Mixxx forum :
https://mixxx.discourse.group/t/mapping-the-roland-rj-202/17099/59
If @Lykos153 and @upCASE could join us on the Mixxx forum to help solve the issues, would be great.
The mapping still works, but some buttons don't stay lit anymore and I had to re MIDI learn Sync buttons. Some little work needs to be done in the .js file.
ronso0
commented
8 months ago IMO it would be best to start with a new PR right away. You can collaborate in that, as well, (open PR against your branches, or provide commits for cherry-picking). IMO that's way easier than sending file updates via forum PM, and you can get dev feedback very early, plus you'd have pre-commit code quality checks in place from the very first commit.
If you collaborate on this it would be very welcome if all involved contributors sign the Mixxx Contributor Agreement.
BSDguy389
commented
8 months ago I already created a private repository if that's what you mean by "PR" and invited the author and the guy who published the files to it.
ronso0
commented
8 months ago Could you share a link please? With "PR" I mean a PR against the Mixxx repo so Mixxx devs can start reviewing it early -- instead of doing the review (and probaly request changes) after you consider the mapping finished, which might be a bit frustrating in case you have to redo certain implementations e.g. to match the Mixxx code quality standards.
BSDguy389
commented
8 months ago I can only invite you to the private repo I made, but the author didn't join it yet, and there are no files. I created it just for the author to notice me.
ronso0
commented
8 months ago The gists is public and you intend to publish the mapping, so why a private repo in the first place?
BSDguy389
commented
8 months ago made the repo as public and added a comment below the original .js file.
BSDguy389
commented
8 months ago It seems that there is already a pull request ; #1595
Donvt worry, that PR has been abandoned. Feel free to open a new PR. I suggest to copy the DJ-505 mapping and strip it down.
I just tried using the DJ-505 mapping, EQ knobs work, sampler level knob works, had to re MIDI learn phones level and phones mix knobs, but the big problem is that performance pads don't work as expected, whereas with the DJ-202 mapping, they work like expected. Mixxx 2.4 displays errors, just ignore them and it works.
ronso0
commented
8 months ago made the repo as public and added a comment below the original .js file.
You mean https://github.com/BSDguy389/Roland-DJ-202-Mixxx ? That's empty.
The usual process is described here https://github.com/mixxxdj/mixxx/blob/main/CONTRIBUTING.md Some more mapping-specific info is on the wiki https://github.com/mixxxdj/mixxx/wiki/Contributing-Mappings In short it's
Hello everyone,
I'm opening this ticket to track my work ( and of others if you're looking towards it ! ) for the Roland DJ-202 controller.
I'm putting links below for reference to the controller and similar mappings or work that already exist in Mixx ;
It's interesting to note that it's very similar to the DJ 505 controller, and if you select it as a mapping when using the DJ 202, most functionalities work and parties have already happened with that mapping. But some don't, and it would be nice to have every thing work, especially the loops and the buttons.
Cheers,