search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.5k stars 1.28k forks source link

Hercules DJ Control MP3 track navigation #11547

Open fbattet opened 1 year ago

fbattet commented 1 year ago

I don't know why, but track navigation with Hercules DJ Control MP3 doesn't work well on 2.5-alpha. It works better if you replace this line https://github.com/mixxxdj/mixxx/blob/a3ad1cd13c9b185a6dc6c7744eba2f7e8e7f1dda/res/controllers/Hercules-DJ-Control-MP3-hid-scripts.js#L341 by : HerculesMP3Hid.scroll_timer = engine.beginTimer(150, function() { HerculesMP3Hid.scroll_tracks(g,e,v) });

daschuer commented 1 year ago

Can you provide a pull request with your change? Here are some hints: https://github.com/mixxxdj/mixxx/wiki/Bugfix-Workflow Alternative you may use the GitHub edit feature if you not plan to do anything else.

daschuer commented 1 year ago

This script has not be changed since Jul 26, 2020. It this issue also available in 2.3.4? If yes, pleas target you pull request against the 2.3 branch.

Swiftb0y commented 1 year ago

Might have be the case that the newer controller engine in 2.4 doesn't support passing callbacks by string anymore. Sounds like a potential regression, yet to be confirmed though.