Dark border around VU-Meter GLGS widgets in 200 % scale

[daschuer]

Bug Description

Since https://github.com/mixxxdj/mixxx/pull/10989 the VU-Meter widgets have a black border.

Version

2.4-alpha

OS

Ubuntu Focal

[daschuer]

@m0dB do you have an idea? Maybe it is related to the issue that the widget thinks it is painted on black and we see antialiasing.

[m0dB]

@daschuer it was something silly, in src/util/texture.cpp I was using

pTexture->setWrapMode(QOpenGLTexture::ClampToBorder);

instead of

pTexture->setWrapMode(QOpenGLTexture::ClampToEdge);

What is the correct procedure to create a PR for a specific issue? Do I give the branch a specific name? Do I just mention the issue in the description?

[ronso0]

Do I just mention the issue in the description?

:+1:

Do I give the branch a specific name?

Whatever works best for you, though I find that handy while collaborating on a certain branch, it's just easier to remember and easier to spot in a git branch list.

[daschuer]

I can confirm that the suggested change fixes the issue. Thank you.

[daschuer]

I have added the fix here: https://github.com/mixxxdj/mixxx/pull/11601

[JoergAtGithub]

Did https://github.com/mixxxdj/mixxx/pull/11722 fix this?

[daschuer]

Yes, I can confirm it is fixed:

[daschuer]

This one is also back on Ubuntu Jammy :-(

[m0dB]

Strange. I'll look into it.

[daschuer]

The fix already lives in https://github.com/mixxxdj/mixxx/pull/11601, I will verify and reopen it.