Closed daschuer closed 1 year ago
@m0dB do you have an idea? Maybe it is related to the issue that the widget thinks it is painted on black and we see antialiasing.
@daschuer it was something silly, in src/util/texture.cpp I was using
pTexture->setWrapMode(QOpenGLTexture::ClampToBorder);
instead of
pTexture->setWrapMode(QOpenGLTexture::ClampToEdge);
What is the correct procedure to create a PR for a specific issue? Do I give the branch a specific name? Do I just mention the issue in the description?
Do I just mention the issue in the description?
:+1:
Do I give the branch a specific name?
Whatever works best for you, though I find that handy while collaborating on a certain branch, it's just easier to remember and easier to spot in a git branch
list.
I can confirm that the suggested change fixes the issue. Thank you.
I have added the fix here: https://github.com/mixxxdj/mixxx/pull/11601
Did https://github.com/mixxxdj/mixxx/pull/11722 fix this?
Yes, I can confirm it is fixed:
This one is also back on Ubuntu Jammy :-(
Strange. I'll look into it.
The fix already lives in https://github.com/mixxxdj/mixxx/pull/11601, I will verify and reopen it.
Bug Description
Since https://github.com/mixxxdj/mixxx/pull/10989 the VU-Meter widgets have a black border.
Version
2.4-alpha
OS
Ubuntu Focal