search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.43k stars 1.27k forks source link

Removal of unmaintained mappings #12045

Open Holzhaus opened 1 year ago

Holzhaus commented 1 year ago

I suggest the removal clearly broken mappings. These seem to be unmaintained and won't work properly which results in a bad impression for new users. We could announce it on the forums and/or our website and ask for help, so that users that actually do use them may step up and help fixing them.

Among those mappings are those who still use the lfoDelay control, which was removed (not just deprecated) in Mixxx 2.0.0 (2015):

daschuer commented 1 year ago

An alternative could be to pop up a disclaimer "Outated mapping, Help wanted" Maye there are still useful parts but that way no one will blame us.

Just an idea, no demand.

ronso0 commented 1 year ago

Good idea IMO. If it's just the Fx components that are broken a warning for 95% mapping is still better than no mapping. We could add that warning to the mapping description.

I expect that especially users with old hardware will be grateful if Mixxx supports them with a somewhat working mapping

fwcd commented 1 year ago

I'd probably just delete the functions that depend on removed APIs and leave the rest up to the user. Fixing a broken mapping is in most cases probably easier than remapping from scratch.

Adding a short note/warning that the mapping is unmaintained sounds good.

joshpatten commented 6 months ago

I just submitted a PR with an updated mapping for the Numark Mixtrack Pro, could you please not kill that one?

ronso0 commented 6 months ago

Don't worry, I think no one had this PR on the radar let alone started working on it ; )

Also, I think we agreed to _not_remove mappings but add a warning to the mapping description.