mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.52k stars 1.28k forks source link

feature request: more/custom pitch slider range #12076

Open ghost opened 1 year ago

ghost commented 1 year ago

Feature Description

Hi

The pitch slider ranges are now fixed and can only be chosen from a given list:

afbeelding

daschuer commented 1 year ago

The chipmunk issue is covered by https://github.com/mixxxdj/mixxx/pull/1767.

Here we "only" need to descried where the ultra slider should go to. I think a reasonable way forward would be to implement a "transport effect" an effect that can be controlled from the effect region in your controller and remote controls the EngineBuffer, the mixer pitch and key control, but with a wider range.

Would that work for you?

For the additional range values, you may edit the mixxx.cfg file directly. That is the "RateRangePercent" value.

Once you are confident your setting is good for you and probably other users you may issue a pull request to add it here: https://github.com/mixxxdj/mixxx/blob/3db5755418a51b709da73bd5a1c07c8fa1da97b6/src/preferences/dialog/dlgprefdeck.cpp#L244 This should be possible with only a minimal programming knowledge.

ghost commented 1 year ago

I'm not a programmer so I can't say anything about this :) (I don't know anything about code)

Can you tell me where mixxx.cfg is on Windows? I can try this maybe. I don't find it in the folder where mixxx is installed

ronso0 commented 1 year ago

https://manual.mixxx.org/2.3/en/chapters/appendix/settings_directory#the-mixxx-settings-directory

ghost commented 1 year ago

For the additional range values, you may edit the mixxx.cfg file directly. That is the "RateRangePercent" value.

That does not work unfortunately.

So I'm still interested in new rate ranges added in Mixxx! :-)

daschuer commented 1 year ago

I need to have a look why the custom range is not kept. Which value you need btw?

ronso0 commented 1 year ago

If the config range value exceeds the max value (90%) the default is used (8%). If we increase the max value to 100% or higher the sliders will allow -100% (stop) and below (playing backwards), but that's currently also possible by setting rate, rate_ratio or bpm to negative values in controller scripts.

ghost commented 1 year ago

Which value you need btw?

It would be nice to add the following in bold text:

4% - 6% - 8% - 10% - 16% - 24% - 50% - 75% - 90% - 100%