search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.4k stars 1.26k forks source link

request: update manual Compatible file formats #12092

Open ghost opened 11 months ago

ghost commented 11 months ago

Feature Description

Hi

I'm extensively testing all lossless, lossy and tracker formats in Mixxx (on Windows). However the manual seems not up-to-date and also tells nothing about supported tracker formats.

Is is possible to update the lossless and lossy formats and add the supported tracker formats in the manual below? This to have a complete overview of all supported formats.

https://manual.mixxx.org/2.3/en/chapters/library#compatible-file-formats

Thanks

ghost commented 11 months ago
ghost commented 11 months ago

Why is ALAC not supported since it's open source now?

https://macosforge.github.io/alac/

ghost commented 11 months ago

I also want to ask if the video formats (of which the audio can be played) can be listed too? I found here MP4 is one of them but are there more?

https://github.com/mixxxdj/mixxx/issues/8034

Holzhaus commented 11 months ago

The problem is that the selection of formats may vary depending on the compile time options. We could add a list of all possibly supported formats and state which one are supported by the binaries we ship.

Also, we should probably thr supported formats to the about dialog window.

ghost commented 11 months ago

The problem is that the selection of formats may vary depending on the compile time options. We could add a list of all possibly supported formats and state which one are supported by the binaries we ship.

Also, we should probably thr supported formats to the about dialog window.

Don't know if it's possible, but could the really supported formats, depending on compile options, be automatically added to the about dialog window? This solves both problems for users (not knowing which formats are in their build and showing them automatically in the about window)

ronso0 commented 11 months ago

Supported file formats are already listed in Preferences > Library, just below the Music Directories box.

I have no objections adding them to About, too :man_shrugging:

ghost commented 11 months ago

Supported file formats are already listed in Preferences > Library, just below the Music Directories box.

I have no objections adding them to About, too 🤷‍♂️

I didn't see it. For me this solves my problem!

ronso0 commented 11 months ago

@Holzhaus Close, or do you think we also need the formats in About?

mxmilkiib commented 11 months ago

Saying "ModPlug" to denote the ability to play tracker module files is not really descriptive to the lay user.

How about listing the types of module file playable in brackets? Maybe just the file extensions though, for brevity?

fwcd commented 11 months ago

Close, or do you think we also need the formats in About?

I have no strong opinion on listing them in the "about" dialog, but updating the manual seems pretty reasonable?

@deejay-girl The manual is open-source, so feel free to open a PR: https://github.com/mixxxdj/manual

Holzhaus commented 11 months ago

@Holzhaus Close, or do you think we also need the formats in About?

Not necessarily, but it would be a nice addition.

foss- commented 11 months ago

Tend to disagree on this. Should supported file formats be documented: certainly. Should supported file formats be mentioned in the about window: not for my taste. Wiki and or manual seem better places for such fine-grained information.

ronso0 commented 11 months ago

I wonder what the benefit is having this in About. One argument might be: most relevant debug info in one place (OS, version, codec information). While this might be Nice to Have:tm:, I don't expect regular users to look for this in About. Also, if there are issues with certain files or file types and users file a bug report we request the log file anyway.

ghost commented 11 months ago

What about:

Swiftb0y commented 11 months ago

The supported audio formats are not very useful to determine the build the user is running, nor would they belong in the "credits". Thus they don't belong in the about window. I think the current place in preferences is appropriate. If people can't find that, we should highlight it better in the manual that they can find their supported formats in the preferences. Putting that info in the manual directly does not work as the supported file formats very much depend on the system you're running mixxx on and the configuration of the build.

mxmilkiib commented 11 months ago

For some reason the Arch binary package About window gives "Git version: unknown".

I guess this is meant to be the short commit sha? Even for a release I don't understand why it's "unknown"

Cos it bears repeating: module formats (not the module playback/rendering library name) in Preferences/Library please! :)

ghost commented 11 months ago

Cos it bears repeating: module formats (not the module playback/rendering library name) in Preferences/Library please! :)

I think this is the repo: https://github.com/Konstanty/libmodplug You can find supported formats there. I agree they should be added in Mixxx somewhere

mxmilkiib commented 11 months ago

Heh, that's quite a few actualy..!

How about ".., tracker modules", with it being text with an underline that gives a cursor with a question mark and a tooltip that lists all the formats? Having it in the UI not the manual makes sense because only a minority of people will ever read the manual.

Tbqf, imho, it's a selling point, so is worthy of mentioning in the copy on the main web page, in the "Broad Format Support" paragraph on the features page, not just in the manual or the preferences window.

P.S. Is the libmodplug to libopenmpt change stalled? https://github.com/mixxxdj/mixxx/issues/9862 (vcpkg already has plain libopenmpt https://github.com/microsoft/vcpkg/pull/2669 without the emulation flag, but doesn't take requests https://github.com/microsoft/vcpkg/issues/17443 and I'm dyslexic and dyscalculic and severly ADHD working memory so couldn't supply a PR)

Holzhaus commented 11 months ago

For some reason the Arch binary package About window gives "Git version: unknown".

I guess this is meant to be the short commit sha? Even for a release I don't understand why it's "unknown"

Unrelated to this issue, but just to explain: if no .git directory is present in the source tree, we cannot determine the git version at build time. And since Arch uses the release tarball instead of checking out the git tag, there is not such directory when the package is built.