mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.46k stars 1.27k forks source link

Make "Reverb" effect support a band pass filter #12504

Open nvdl opened 9 months ago

nvdl commented 9 months ago

Feature Description

Mixxx 2.4.0-beta Git Version: 2.4-beta-314-g71dceb27ba Platform: Linux x86_64

There may be another way to handle this about which I am not aware.

Now, the "reverb" effect only supports a low pass filter and there is no way to add an effect to the mid frequencies only e.g. vocals. In most of the cases, I do not want to add reverb to the bass.

It will be nice to have "LPF" and "HPF" knobs for this effect that allow selection of a specific band for the effect.

ronso0 commented 9 months ago

If used as a single effect a second filter makes sense. So :+1: for the feature request.

However that would only be required for the QuickEffect slots, but otoh those don't give access to all parameters.

FYI in all effect units effects are chained, i.e. applied one on top of the other: 1 -> 2 -> 3¹. You could use a filter in slot1 and Reverb in slot2, so the filter's output is the input for the Reverb.

¹each effect unit has 4 slots, though only 3 are exposed in the GUI because that's the typical layout on MIDI/HID controllers.

nvdl commented 9 months ago

"Reverb" already has a LPF and a related bandwidth knob for it (don't know the historical reason for that). In my case, it would have been enough if it were a HPF with a configurable bandwidth.

If I add a band pass filter before "Reverb" in the chain, it affects the bass that I do not want to modify. If I use the "Dry/Wet" ratio knob to reduce the effect of the filter on the bass, it also reduces the reverb effect.

The "Dry+Wet" mode with a filter before the reverb does the trick.

Still, it will be nice to have a band pass filter with one knob for the center frequency and another knob for the bandwidth. Just tweaking the center frequency will be fun then.

ronso0 commented 9 months ago

The "Dry+Wet" mode with a filter before the reverb does the trick.

👍