mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.5k stars 1.28k forks source link

Pioneer FLX-4 crossfader inverted (hamster style) #12622

Closed ghost closed 9 months ago

ghost commented 9 months ago

CASE CLOSED I WILL NO LONGER USE MIXX SOFTWARE

Swiftb0y commented 9 months ago

it should work. have you made sure to apply the preferences correctly? If so, please start mixxx from the commandline with the --controllerDebug flag. then move the crossfader from left to right once! and post the commandline output produced while moving the fader here. Thank you.

Swiftb0y commented 9 months ago

That sounds like a problem with the mapping (unlikely from what I can tell right now) or your hardware.

also im on windows so --controllerDebug from command line DOSE not work !

I'm not on windows but I'm pretty sure you can start mixxx from the commandline and the flag should work (am I wrong @JoergAtGithub?). Just open the path where mixxx is installed in cmd and then execute mixxx.exe --controllerDebug.

Anyways, if that still doesn't work, you can try a third party programm like midi-ox to take a look at the midi messages sent by the controller. They should be 0x6B 0x1F and 0x6B 0x3F and if you move the crossfader from left to right, the values for the 0x1F control should be ascending.

Also, please post a copy of your mixxx.cfg file. It should be in the same directory as your mixxx.log file

Swiftb0y commented 9 months ago

Ah, I overlooked that fact. Can you link me the exact forum post? That mapping is probably buggy. If you instead use mixxx 2.4 (don't worry its pretty stable) you will find a mapping for the FLX4 built-in (make sure you remove the forum mapping first) which has not received any complaints so far.

Swiftb0y commented 9 months ago

Good to know. Then in that case I'd need to see the midi messages. I must also ask you to mind your tone. I'm not willing to assist you further if your responses remain this aggressive. Thank you.

Swiftb0y commented 9 months ago

As a quick workaround you can try adding <inverted/> tags to the <options> in the xml that belong to the two <key>crossfader</key> <control>s. Not sure how reliable that is.

Swiftb0y commented 9 months ago

then I recommend you to look at the wiki page that will introduce you to the structure of a basic midi mapping: https://github.com/mixxxdj/mixxx/wiki/MIDI controller mapping file format

ronso0 commented 9 months ago

As a quick workaround you can try adding <inverted/> tags to the <options> in the xml that belong to the two <key>crossfader</key> <control>s. Not sure how reliable that is.

You need to go to Preferences -> Controllers -> FLX4 The click on the FLX4-...xml file link to open that file in a text editor. Find the two controls for "crossafder" and add <Invert/> into the options nodes, right below each <fourteen-bit...> node. https://github.com/mixxxdj/mixxx/blob/7ab184441dfe51eec7455bf7be86d4f4f6dab880/res/controllers/Pioneer-DDJ-FLX4.midi.xml#L624-L643

If that file is write-protected on Windows, yo need to both the FLX xml and js files to your /controllers first, the edit. https://manual.mixxx.org/2.4/en/chapters/appendix/settings_directory.html

Swiftb0y commented 9 months ago

Yes me too. The only way forward of debugging this is to get a look into what the controller is actually doing, which is why I asked for the midi info produced by --controllerDebug or midi-ox.

Swiftb0y commented 9 months ago

So its not immediately apparent from the log, did you move the crossfader left-right-left or right-left-right?

Swiftb0y commented 9 months ago

whats your crossfader reversal setting in rekordbox?

Swiftb0y commented 9 months ago

yes, but which one of those...

Swiftb0y commented 9 months ago

yes. that is also apparent. My question is what orientation the crossfader was when you started and ended the recording. Did you start with the crossfader on the left or on the right? That is crucial for me to understand whether the controller is sending signals inverted or mixxx is interpreting them inverted.

Swiftb0y commented 9 months ago

may be the case. But I'm still not sure what the issue is. It could also be the controller and mixxx not accounting for it correctly (still the fault of mixxx, but I need more data to understand where the issue lies exactly).

So with some guesswork it seems the controller is behaving as expected. I'll try to look further into it.

Swiftb0y commented 9 months ago

No worries I think I found the problem.

Swiftb0y commented 9 months ago

nevermind. I misunderstood the feature. So I need more clarification. When you say it is inverted, does that mean that the movement of your crossfader does not match the onscreen movement or does that mean that when the crossfader is on the left the left deck is still muted?

Swiftb0y commented 9 months ago

okay, that is unrelated to the hamster style preference option. That will only change the output sound, not the visual. What skin are you using? Can you send me another midi-ox log? Preferable one containing just the messages from one slide from the left to the right.

Swiftb0y commented 9 months ago

Okay thank you. The controller is sending the correct messages. I have no idea right now why this is happening.

Swiftb0y commented 9 months ago

Do that then. I'll close this for now. feel free reopen if this comes up again for someone else. I'll try to get a hold of an FLX4 in the meantime.

grizeldi commented 9 months ago

I retested the latest binding I could find in the linked forum thread (from this post https://mixxx.discourse.group/t/pioneer-ddj-flx4/26553/24?u=grizeldi), as the binding is merged only into 2.4 and not into 2.3 branch. The crossfader seems to behave as intended, I can't find anything that would be inverted.

Ubuntu 23.10, 64 bit Mixxx 2.3.6 (flatpak from flathub) ALSA audio backend

grizeldi commented 9 months ago

Next up, Windows 10 test. This time on the 2.4 branch with the official binding, so we can actually know which binding we're talking about. No crossfader issues to be found here either. My deck 1 fader did jiggle a bit up and down in Mixxx when I was cutting with the crossfader, but I'd attribute that to the fader being slightly worn out and moving with the vibrations, not to a software issue.

Windows 10 Home, 64 bit Mixxx 2.4-beta-394-gd1c0de51b0 from the official website ASIO audio backend

grizeldi commented 9 months ago

@Kris-Dorey I have read through this entire conversation, most of which consist of you giving vague answers which don't help debugging at all in a rather condescending tone. Have some patience, we're all working on this in our free time. I am here exclusively because the devs requested someone with a FLX4 to test what is going on in the original FLX4 issue. I'm not here to judge whether there's a bug or not, just to tell the devs that in my testing I couldn't reproduce the issue.

Good luck getting this sorted out, I'm out.

mxmilkiib commented 9 months ago

@Kris-Dorey Hey hey now, cross-checking is always worth trying, and it's not uncommon in the world of open source. And I've been utterly sure for days that there has been a bug in software before, and eventually it turns out it was a setting somewhere (this is sometimes known as PEBKAC). No need to get violent with your words, you can always ignore.

ghost commented 9 months ago

@Kris-Dorey I have read through this entire conversation, most of which consist of you giving vague answers which don't help debugging at all in a rather condescending tone. Have some patience, we're all working on this in our free time. I am here exclusively because the devs requested someone with a FLX4 to test what is going on in the original FLX4 issue. I'm not here to judge whether there's a bug or not, just to tell the devs that in my testing I couldn't reproduce the issue.

Good luck getting this sorted out, I'm out.

Good riddance rude boy

Swiftb0y commented 9 months ago

@grizeldi I'm sorry this escalated like this. Thank you for trying to confirm the issue, I'm sorry you got dragged into this.

grizeldi commented 9 months ago

It's not your fault, it happens I guess. It'll serve me as a reminder not to bother with issues where I'm already seeing red flags just by reading through existing correspondence.

Swiftb0y commented 9 months ago

Thats a fair takeaway, regardless I still appreciate your comments as without them I would've considered this issue valid and would've wasted more time on it.