search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.44k stars 1.27k forks source link

Mixer > Main EQ > Graphic Equalizer isn't usable #12630

Open idcmp opened 8 months ago

idcmp commented 8 months ago

Bug Description

Apologies if this is fixed in a newer version.

image

  1. the yellow you see is the text from my crates in the main Mixxx window, somehow shining through the Preferences window.
  2. clicking on the circle in the slider will cause the EQ amount to jump wildly.
  3. clicking on a slider will cause other sliders to shift slightly (but the values stay the same).

The values change too violently to use this live to make adjustments. I can take a video snapshot if that helps.

Version

2.4-beta-328-gf610d58a25

OS

macOS arm64

ronso0 commented 8 months ago

At least the opacity issue should have been fixed by #11647 Can you confirm the waveforms framerate slider and the end-of-track slider work as desired? If yes, it may be that the fix from #11647 only applies to existing sliders (instantiated by the .ui files). In contrast, the main EQ sliders are added on demand, when the effect settings are restored and when the main EQ effect is changed. So maybe an update() or style()->polish() call solves the issue.

The other issues are new.

ronso0 commented 8 months ago

Potential fix is #12631, please test!

daschuer commented 8 months ago

Is this a regression compared to 2.3.6?

daschuer commented 8 months ago

It is a regression compared to 2.3.6 and 2.5-alpha Since we have no idea how to solve it, I have removed the experimental PRs from the 2.4 milestone. It will be fixed with the 2.5 release.

fwcd commented 8 months ago

Seems to be a Qt 5 bug, I've added some notes here: https://github.com/mixxxdj/mixxx/pull/12711#issuecomment-1925974979

idcmp commented 7 months ago

@daschuer Running 1c6b44c29d (gh12630) (off of your fork), I still experience this problem.

fwcd commented 7 months ago

That looks like a 2.4 build, which presumably still has the buggy Qt 5 version. We'll either have to patch Qt or you could try the 2.5 snapshots, which run Qt 6 and shouldn't have the issue.

idcmp commented 7 months ago

Grabbed 2.5-alpha-250-gd21cb08ce3 (main)

Can confirm the Graphic Equalizer has gone from broken to just frustrating. (Which is an improvement!)

The knob is quite large, and it's almost impossible to click on the knob without causing the value to change, and it's not obvious how it will change when I click.

Infact, because the movement of the knob isn't 1:1 with the movement of my pointer on the screen, it's possible to click-and-drag, but then let go - and without moving my mouse - click again and cause the EQ knob to move.

daschuer commented 7 months ago

Can you check out: https://github.com/mixxxdj/mixxx/pull/12711

Does it make any difference? Are you able to build from source and merge this to the main branch? I am curious if this removes the "frustration" as well.

idcmp commented 7 months ago

Unfortunately I don't have a dev toolchain installed on this Mac, and that's not an undertaking I have time for right now. If there's a PR-build I can download, I don't mind giving it a try though.

I will probably do it eventually as I need to remove "Add to AutoDJ (replace)" from the popup menu. 😭

daschuer commented 7 months ago

I will probably do it eventually as I need to remove "Add to AutoDJ (replace)" from the popup menu. 😭

Can you file an issue for this? We may make it conditional via preferences or add a "really?" pop up.

daschuer commented 7 months ago

Please test the Qt6 build you will find here: https://github.com/mixxxdj/mixxx/actions/runs/8001196736?pr=12862