mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.45k stars 1.27k forks source link

MIDI for light: beat clock #12671

Open mcallegari opened 8 months ago

mcallegari commented 8 months ago

Bug Description

Hi all! First off, congratulations for the great software!

While developing new features in QLC+ for DJs, I noticed that the MIDI for light script outputs the beat signal as a MIDI note: https://github.com/mixxxdj/mixxx/blob/main/res/controllers/Midi_for_light-scripts.js#L519

I find this a bit awkward, since the MIDI protocol offers dedicated messages for MBC: https://github.com/mcallegari/qlcplus/blob/master/plugins/midi/src/common/midiprotocol.h#L121

At the moment, QLC+ can detect that message as a generic signal, but in version 5 I will offer a real BPM based system to run beat-based cues so I need to recognize exactly a "beat" message without mistaking it with something else. Would you be willing to standardize that message?

Thanks!

Version

2.3.6

OS

Ubuntu 22.04

Swiftb0y commented 8 months ago

Hey there, great to hear from you. QLC+ is a great piece of software as well (I've personally used it on gigs in conjunction with mixxx). I very much invite you to join our zulip (https://mixxx.zulipchat.com/) to discuss details. This is probably of interest to @brunchboy (creator and maintainer of beat-link-trigger) as well.

mcallegari commented 8 months ago

@Swiftb0y I joined Zulip, now what? :smiley:

brunchboy commented 8 months ago

Nice to hear from you again, Swiftb0y. Beat Link Trigger has supported MIDI beat clock since its earliest releases, but that is a terrible synchronization protocol. It can communicate tempo changes, although with lag and little precision, but it does not communicate anything about the actual position of beats or bars. Today Ableton Link offers a far more precise, efficient, stable, and useful mechanism for synchronizing tempo, beat, and optionally measure information across a network.

JoergAtGithub commented 8 months ago

You might try my experimental Ableton Link PR: #10999

Swiftb0y commented 8 months ago

@Swiftb0y I joined Zulip, now what? 😃

Thank you. I've opened a thread on zulip where its easier to discuss complex topics like this. I propose to continue the discussion there. https://mixxx.zulipchat.com/#narrow/stream/109122-general/topic/Mixxx.20.26.20QLC.2B.20integration