mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.5k stars 1.28k forks source link

Bitrate of m4a-files is influeced by giving the song a color. #12755

Open Eve00000 opened 8 months ago

Eve00000 commented 8 months ago

Bug Description

after giving a m4a song a color, the displayed bitrate changes. Setting color back to black (default) han no effect on the displayed bitrate. This does not happen on mp3

Version

2.5-alpha-229-g7b3e48544a (main)

OS

win 10

ronso0 commented 8 months ago

I can not reproduce this (with 2.4). Could you attach a small screencast demonstrating the issue?

Eve00000 commented 8 months ago

https://github.com/mixxxdj/mixxx/assets/159239887/50c78f82-99a4-4d50-bae3-1c580ee21556

ok, the select-color-overlay was not recorded but I selected a color, you can see the new bitrate and then I put back the default color and the bitrate remains.

Swiftb0y commented 8 months ago

I think this is unrelated to the color and something else fishy is happening here. m4a audio files should not have a bitrate > 1000... Also, the recording does not seem to show the rightclick menu probably because of window capture instead of screen capture.

Swiftb0y commented 8 months ago

to clarify, did this only happen to tracks where you changed the color? have you tried changing other attributes on these tracks?

Eve00000 commented 8 months ago

For the record, I have files with a much higher bitrate... afbeelding

As you mentioned, I tried with changing other things (genre ...) and indeed something else 'fishy' is happening, not only with selecting another color. Properties -> import metadata again from files solves the problem ..... until I select another file. At that moment the fishy thing happens that changes the bitrate.

ronso0 commented 8 months ago

Might be related #12467 Issue was gone after a library rescan.

Swiftb0y commented 8 months ago

For the record, I have files with a much higher bitrate...

Good point, I forgot that m4a files can also contain ALAC which obviously has a much higher bitrate than AAC.

Eve00000 commented 8 months ago

All my tracks are ALAC, because iTunes does not support FLAC....

Eve00000 commented 8 months ago

Might be related #12467 Issue was gone after a library rescan.

after rescan nothing schanged, in id tag has still correct bitrate

Swiftb0y commented 8 months ago

so no AAC either than? Is the reading in mixxx correct before you change the color and then wrong or wrong to begin with and only correct after you changed the color, or always wrong (according to your tagger of choice)?

Eve00000 commented 8 months ago

I don't play compressed music, only lossless I tried it on other pc with 2.3.6, no problem: bitrate stays correct after changing color, genre ....

Swiftb0y commented 8 months ago

Good to know, what is different about that PC exactly?

Eve00000 commented 8 months ago

Other pc = version 2.3.6, this is my live-pc

Swiftb0y commented 8 months ago

ahh good catch, I wasn't realizing that you were using main. Are you comfortable with compiling code from source? Does the same issue occur with 2.4-beta too?

Eve00000 commented 8 months ago

I don't want to install beta's or alpha's on my live pc, studio pc has now 2.5-alpha-229-g7b3e48544a (main) No compiling for me, but sownlading from http://downloads.mixxx.org/releases/2.4-beta/

I tried 2.4 beta,, I installed it on a vmware Win 11 machine Windows x86_64 Git Version: 2.4-beta (HEAD) I added some songs (m4a / mp3 / flac) and tried changing colour, genre .... I can change as much as I want, nothing fishy happens to bitrate....

is this helping you?

ronso0 commented 8 months ago

You can safely test other versions if you backup your data, and roll back if you go back to the stable version. https://github.com/mixxxdj/mixxx/wiki/Testing

Eve00000 commented 8 months ago

Thank you, I've read that item. I make a lot of BU's, so no problem of loosing data. It was no big problem testing in a virtual machine.

Eve00000 commented 6 months ago

2.4.1 : Bitrate is still a problem ....