search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.46k stars 1.27k forks source link

Caps Lock Indicator in Library #12982

Open idcmp opened 7 months ago

idcmp commented 7 months ago

Bug Description

On macOS, the OS will float a red capslock indicator at the cursor so you KNOW YOU'RE YELLING. This also happens in Mixxx on the selected track:

image

Version

2.4.0

OS

macOS/arm64 14.4

ronso0 commented 7 months ago

Why is this an issue, and what should Mixxx do about it in your opinion?

idcmp commented 7 months ago

@ronso0 Usually on macOS the caps lock indicator is only where a cursor in a text field is located.

image

I don't think that text is meant to be editble, and even if it is (for some reason), it's pointing to the wrong row? So ideally it just wouldn't show that at all.

ronso0 commented 7 months ago

I see. Do you have library inline-editing enabled? Do you have keyboard shortcuts enabled? How does toggling both options affect the indicator?

idcmp commented 7 months ago

I've always had inline editing mode truned off. Turning it on and clicking on the song title, launches me into edit mode. The caps lock indicator is still in the wrong place until I touch a key, then it jumps to where I'd expect it to be:

image

(after presing a key the capslock indicator jumps to the right place)

ronso0 commented 7 months ago

Okay, and

Do you have keyboard shortcuts enabled?

idcmp commented 7 months ago

I couldn't find anything about keyboard shortcuts in settings so I'm not sure.

That said, Cmd-F will take me to the search box - so yes?

image
ronso0 commented 7 months ago

It's in the Options menu.

Ctrl+F is one of the hard-coded, always-on hotkeys (like Space to maximize the library, Ctrl+R for recording etc.)

idcmp commented 7 months ago

Ah! Yes, it's enabled. Assuming I don't need to restart, I still get the caps lock indicator when it's disabled.

ronso0 commented 7 months ago

Well, I doubt Mixxx can do anything about it. I'd say it's a Qt issue, or rather a not quite perfect way of macOS to detect 'editable' fields. In both cases it'll likely take some time until it's fixed. I suggest you report the issue to Qt (the library is a QTableView).

FWIW this entire 'feature' capslock indicator seems to annoy many users. And it can be turned off only via command line. (and I don't get why it's necessary in the first place: there's a CapsLock LED on Apple keyboards + you notice Caps is on when you type, so what?)

fwcd commented 7 months ago

Funnily enough, the caps lock indicator shows up on tracks, but not in the search bar where it would actually be useful...

But yeah, this has tripped me up a bit too, I think macOS Sonoma introduced it. The keyboard language picker that randomly pops up every now and then falls in a similar vein...

idcmp commented 7 months ago

but not in the search bar where it would actually be useful..

Hah! Can confirm.